Page MenuHomePhabricator

efl.ui.textbox: move file implementation in to internal class
ClosedPublic

Authored by ali.alzyod on Jan 22 2020, 1:42 AM.

Details

Summary

We want to keep implementation for file interface in a safe place and remove it from our side world (eo).

This is a simple copy-paste, from efl.ui.textbox into efl_ui_internal_text_interactive

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ali.alzyod created this revision.Jan 22 2020, 1:42 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Jan 22 2020, 1:42 AM
ali.alzyod edited the summary of this revision. (Show Details)Jan 22 2020, 1:46 AM
ali.alzyod added reviewers: woohyun, bu5hm4n.

I'm ok with this patch because efl_ui_textblock class has a composite relation with efl_ui_internal_text_interactive class
So, the file method would not be exposed from efl_ui_textblock.
In conclusion, we achieve the goal for keeping file codes internally :)

@bu5hm4n
Do you have better idea on this ?

bu5hm4n accepted this revision.Jan 23 2020, 12:43 AM

Looks good to me.

This revision is now accepted and ready to land.Jan 23 2020, 12:43 AM
Closed by commit rEFL279f2eca06f7: efl.ui.textbox: move file implementation in to internal class (authored by ali.alzyod, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyJan 23 2020, 1:04 AM
This revision was automatically updated to reflect the committed changes.