Page MenuHomePhabricator

Revert "efl_ui_image: Call unload file when calling file_set"
ClosedPublic

Authored by jsuya on Jan 22 2020, 11:49 PM.

Details

Summary

This reverts commit 93bd97025983e48ae8048d0c63b5d8b314f1de42.
efl.ui.image using prev and current inner image object.
Unloading the efl.ui.image class can be unloaded up to the prev image.
And because efl.ui.image is using the image caching feature together,
it may get unexpected errors. Therefore, revert this patch.

Test Plan

N/A

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jsuya created this revision.Jan 22 2020, 11:49 PM
jsuya requested review of this revision.Jan 22 2020, 11:49 PM
Hermet accepted this revision.Jan 23 2020, 12:24 AM
This revision is now accepted and ready to land.Jan 23 2020, 12:24 AM
This revision was automatically updated to reflect the committed changes.
zmike added a subscriber: zmike.Jan 23 2020, 6:01 AM

@jsuya The unit tests still pass with this diff applied. It may be worthwhile to add a unit test here to avoid others attempting the same patch in the future.