Page MenuHomePhabricator

efl_ui: rename Layout_Factory to Generic_Factory.
Needs RevisionPublic

Authored by SanghyeonLee on Jan 23 2020, 4:36 AM.

Details

Summary

Layout_Factory is too narrow as the name for this class.
Our usage for the MVVM view-factory support
is not only for items, but also the contents such as
button, radio, image, check widget.
as it is generic factory for all Efl.Ui.Widget based object,
rename it to Generic_Factory,
and remove unnecessary method(theme_config).

This class is out of @beta,
but not released yet, targeted efl 1.24.
I think still we have the chance to change the name and re-stablizing it.

Test Plan

tested in existing test case,
examples, elemetary_test
and mono examples.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15584
Build 10686: arc lint + arc unit
SanghyeonLee created this revision.Jan 23 2020, 4:36 AM
SanghyeonLee requested review of this revision.Jan 23 2020, 4:36 AM
SanghyeonLee edited the summary of this revision. (Show Details)Jan 23 2020, 4:42 AM
cedric requested changes to this revision.Jan 23 2020, 8:25 AM

I am not convinced by this change as we loose the ability to set the theme during widget creation.

This revision now requires changes to proceed.Jan 23 2020, 8:25 AM

I think we get agreement about this patch, so if I update new layoutFactory depends on this patch, it is ready for accept, am I right @cedric?

As long as you do not replace layout factory, but add a new generic factory which layout inherit from, yes.

@cedric please re-check this patch with D11227