evas/events: fix multi-touch object targeting on touch down events
ClosedPublic
Actions

Authored by zmike on Jan 23 2020, 12:25 PM.

Details

Reviewers

CHAN
cedric

Commits

rEFL12a064874efe: evas/events: fix multi-touch object targeting on touch down events

Summary

a touch press is both a touch and a move event, which means the canvas must
update its list of target objects on the first touch press to avoid using the
wrong objects when processing events

@fix

Depends on D11155

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

zmike created this revision.Jan 23 2020, 12:25 PM

Herald added subscribers: committers, reviewers, cedric. · View Herald TranscriptJan 23 2020, 12:25 PM

zmike requested review of this revision.Jan 23 2020, 12:25 PM

zmike added a child revision: D11164: efl/gesture: break out _direction_get() into helper function.

Harbormaster completed remote builds in B15607: Diff 28447.Jan 23 2020, 12:32 PM

@zmike

I think I know what the intended commit is, though

Please let me know in which case the issue occurred.

I will look around that case to check some cases.

Thank you.

@CHAN I don't recall exactly, but at least one of the gesture unit tests I wrote was failing without this.

rebase/rework

Harbormaster completed remote builds in B15795: Diff 28668.Jan 29 2020, 11:34 AM

cedric accepted this revision.Jan 29 2020, 2:36 PM

This revision is now accepted and ready to land.Jan 29 2020, 2:36 PM

Closed by commit rEFL12a064874efe: evas/events: fix multi-touch object targeting on touch down events (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyFeb 5 2020, 1:14 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/lib/evas/canvas/evas_events.c (42 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	28447	1671b45		Jan 23 2020, 12:25 PM	★	★
Diff 2	28668	cbd088d	rebase/rework	Jan 29 2020, 11:20 AM	★	★
Diff 3	28827	a1222c7	rEFL12a064874efea0553a2fc350456fc9d23cca97e6	Feb 5 2020, 1:09 AM	★	★

Status	Author	Revision
Closed	zmike	D11244 efl/gesture: remove unused manager function
Closed	zmike	D11243 evas/object: remove weird gesture manager method
Closed	zmike	D11242 efl/gesture: free object gesture list in destructor
Closed	zmike	D11241 efl/gesture: use array instead of list for garbage gesture objects
Closed	zmike	D11240 efl/gesture: fix gesture object cleanup when unregistering a recognizer
Closed	zmike	D11239 tests/gesture: add second custom recognizer test
Closed	zmike	D11238 tests/elm: add explicit printf for event cb assert failure
Closed	zmike	D11224 tests/gesture: add custom recognizer test
Closed	zmike	D11223 efl/gesture: implement custom gesture recognizer framework
Closed	zmike	D11222 efl/gesture: break out gesture processing code into separate function
Closed	zmike	D11221 efl/gesture: remove manager's recognizer_get method
Closed	zmike	D11220 tests/gesture: change random momentum cb to be useful momentum cb
Closed	zmike	D11209 tests/gesture: add a 10-touch tap test
Closed	zmike	D11208 efl/gesture: conditionally ignore multi-touch unpress events in zoom recognizer
Closed	zmike	D11207 efl/gesture: ignore successive press events in zoom recognizer when canceled
Closed	zmike	D11206 efl/gesture: ignore multi-touch end events in tap gesture recognizer
Closed	zmike	D11198 efl/gesture: avoid direct double access in structs
Closed	zmike	D11197 efl/gesture: reorder gesture private structs
Abandoned	zmike	D11179 efl/gesture: remove recognizer::reset method
Closed	zmike	D11178 efl/gesture: remove 'gesture' member from recognizer data struct
Closed	zmike	D11177 efl/gesture: remove 'manager' member from recognizer data struct
Closed	zmike	D11176 efl/gesture: remove 'config' property from recognizers
Closed	zmike	D11175 efl/gesture: expose 'continues' as a public property for recognizers
Closed	zmike	D11174 efl/gesture: add an event to notify when a config value has been changed
Closed	zmike	D11173 efl/gesture: move finger_size into private structs of recognizers
Closed	zmike	D11170 tests/gesture: add zoom and pinch tests
Closed	zmike	D11169 efl/gesture: discard non-press events for all touch points if unseen previously
Closed	zmike	D11168 efl/gesture: add 'pressed' state info for touch data
Closed	zmike	D11167 efl/gesture: correctly reset zoom gesture recognizer data on >2 finger touch
Closed	zmike	D11166 tests/elm: add util function for doing pinch motions
Closed	zmike	D11165 efl/gesture: more accurately handle flick/momentum recognition with multi-touch
Closed	zmike	D11164 efl/gesture: break out _direction_get() into helper function
Closed	zmike	D11163 evas/events: fix multi-touch object targeting on touch down events
Closed	zmike	D11155 efl/gesture: correct config value name for glayer_double_tap_timeout
Closed	zmike	D11145 tests/gesture: add extra event callback to verify event multiplication is fixed
Closed	zmike	D11144 efl/gesture: redo (and make stupider) hash usage in gesture manager
Closed	zmike	D11126 efl/gesture: add touch_count property for gesture event info
Closed	zmike	D11090 tests/gesture: add gesture tests for basic multi-touch tap events
Closed	zmike	D11089 tests/elm: add util functions for doing multi-touch events
Closed	zmike	D11088 efl/gesture: fix zoom to ignore single press events and not crash
Closed	zmike	D11087 efl/gesture: restrict flick and momentum gestures to original touch point
Closed	zmike	D11086 efl/gesture: handle multi-touch press for tap gestures

Diff 28827

View Options

src/lib/evas/canvas/evas_events.c