if we have one of these gestures where we are flicking/momentuming with multiple
touch points, we want to permit this so long as the touch points are moving vaguely
in the same direction, e.g., press -> swipe with 2 fingers
with this, we now cancel these gestures with multi-touch active if we detect motion
with subsequent touch events that doesn't match the vector of the "active" press
for which we are monitoring events
Depends on D11164
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Please check comment thank you.
| src/lib/evas/gesture/efl_canvas_gesture_recognizer_flick.c | ||
|---|---|---|
| 238 | Even if we cancel the flick gesture because the direction of the two fingers is different, | |
| src/lib/evas/gesture/efl_canvas_gesture_recognizer_momentum.c | ||
| 112 | The momentum gesture concept triggers when there is momentum even when the moving is not like line. | |
| src/lib/evas/gesture/efl_canvas_gesture_recognizer_flick.c | ||
|---|---|---|
| 238 | I'm not sure. I can't really think of a scenario where we'd expect this to work? Maybe if someone does a zoom then a flick? But wouldn't they release their fingers after the zoom? | |
| src/lib/evas/gesture/efl_canvas_gesture_recognizer_momentum.c | ||
| 112 | Oh, is it? According to the docs, this is a swipe, which I thought was supposed to be vaguely linear? | |
| src/lib/evas/gesture/efl_canvas_gesture_recognizer_flick.c | ||
|---|---|---|
| 238 | Even if the flick gesture is aborted, it recognizes again when move is detected. I think the continue value should be true in this case. Am I misunderstanding the case? | |
| src/lib/evas/gesture/efl_canvas_gesture_recognizer_momentum.c | ||
| 112 | Yes i think so. the gesture layer doc said that The momentum gesture is used for detecting any move events on the gesture layer and getting event information to make a meaningful gesture action. The momentum gesture is used for detecting line, zoom, and rotate gestures as well. But its kinda legacy. if you have better idea lets discuss. | |
| src/lib/evas/gesture/efl_canvas_gesture_recognizer_momentum.c | ||
|---|---|---|
| 112 | In the current code here, the gesture recognizers are all totally independent and there is no dependency. Perhaps I misunderstood your meaning here. The intent here is to keep momentum (swipe) as being an actual swipe and not just moving a finger around randomly, which can be tracked by a custom recognizer or just monitoring multi move events. | |