efl/gesture: discard non-press events for all touch points if unseen previously
ClosedPublic
Actions

Authored by zmike on Jan 23 2020, 12:26 PM.

Details

Reviewers

Commits

rEFLff8e8fd5f8c0: efl/gesture: discard non-press events for all touch points if unseen previously

Summary

not sure why this was restricted to first touch point previously, but the logic
applies to all points as we don't want to be tracking input for a touch we
haven't gotten a down for

Depends on D11168

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

zmike created this revision.Jan 23 2020, 12:26 PM

Herald added subscribers: committers, reviewers, cedric. · View Herald TranscriptJan 23 2020, 12:26 PM

zmike requested review of this revision.Jan 23 2020, 12:26 PM

zmike added a child revision: D11170: tests/gesture: add zoom and pinch tests.

Harbormaster completed remote builds in B15613: Diff 28453.Jan 23 2020, 12:32 PM

Um... i changed @smohanty 's first concept. so that code is kinda legacy...

Looks good to me.

This revision is now accepted and ready to land.Jan 28 2020, 3:39 AM

rebase/rework

Harbormaster completed remote builds in B15801: Diff 28674.Jan 29 2020, 11:34 AM

Closed by commit rEFLff8e8fd5f8c0: efl/gesture: discard non-press events for all touch points if unseen previously (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyFeb 5 2020, 1:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/lib/evas/gesture/efl_canvas_gesture_touch.c (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	28453	0ac5244		Jan 23 2020, 12:26 PM	★	★
Diff 2	28674	d7967e5	rebase/rework	Jan 29 2020, 11:21 AM	★	★
Diff 3	28832	bf0fe4a	rEFLff8e8fd5f8c02425601feaafee57eb8d3b3cf4ce	Feb 5 2020, 1:10 AM	★	★

Status	Author	Revision
Closed	zmike	D11244 efl/gesture: remove unused manager function
Closed	zmike	D11243 evas/object: remove weird gesture manager method
Closed	zmike	D11242 efl/gesture: free object gesture list in destructor
Closed	zmike	D11241 efl/gesture: use array instead of list for garbage gesture objects
Closed	zmike	D11240 efl/gesture: fix gesture object cleanup when unregistering a recognizer
Closed	zmike	D11239 tests/gesture: add second custom recognizer test
Closed	zmike	D11238 tests/elm: add explicit printf for event cb assert failure
Closed	zmike	D11224 tests/gesture: add custom recognizer test
Closed	zmike	D11223 efl/gesture: implement custom gesture recognizer framework
Closed	zmike	D11222 efl/gesture: break out gesture processing code into separate function
Closed	zmike	D11221 efl/gesture: remove manager's recognizer_get method
Closed	zmike	D11220 tests/gesture: change random momentum cb to be useful momentum cb
Closed	zmike	D11209 tests/gesture: add a 10-touch tap test
Closed	zmike	D11208 efl/gesture: conditionally ignore multi-touch unpress events in zoom recognizer
Closed	zmike	D11207 efl/gesture: ignore successive press events in zoom recognizer when canceled
Closed	zmike	D11206 efl/gesture: ignore multi-touch end events in tap gesture recognizer
Closed	zmike	D11198 efl/gesture: avoid direct double access in structs
Closed	zmike	D11197 efl/gesture: reorder gesture private structs
Abandoned	zmike	D11179 efl/gesture: remove recognizer::reset method
Closed	zmike	D11178 efl/gesture: remove 'gesture' member from recognizer data struct
Closed	zmike	D11177 efl/gesture: remove 'manager' member from recognizer data struct
Closed	zmike	D11176 efl/gesture: remove 'config' property from recognizers
Closed	zmike	D11175 efl/gesture: expose 'continues' as a public property for recognizers
Closed	zmike	D11174 efl/gesture: add an event to notify when a config value has been changed
Closed	zmike	D11173 efl/gesture: move finger_size into private structs of recognizers
Closed	zmike	D11170 tests/gesture: add zoom and pinch tests
Closed	zmike	D11169 efl/gesture: discard non-press events for all touch points if unseen previously
Closed	zmike	D11168 efl/gesture: add 'pressed' state info for touch data
Closed	zmike	D11167 efl/gesture: correctly reset zoom gesture recognizer data on >2 finger touch
Closed	zmike	D11166 tests/elm: add util function for doing pinch motions
Closed	zmike	D11165 efl/gesture: more accurately handle flick/momentum recognition with multi-touch
Closed	zmike	D11164 efl/gesture: break out _direction_get() into helper function
Closed	zmike	D11163 evas/events: fix multi-touch object targeting on touch down events
Closed	zmike	D11155 efl/gesture: correct config value name for glayer_double_tap_timeout
Closed	zmike	D11145 tests/gesture: add extra event callback to verify event multiplication is fixed
Closed	zmike	D11144 efl/gesture: redo (and make stupider) hash usage in gesture manager
Closed	zmike	D11126 efl/gesture: add touch_count property for gesture event info
Closed	zmike	D11090 tests/gesture: add gesture tests for basic multi-touch tap events
Closed	zmike	D11089 tests/elm: add util functions for doing multi-touch events
Closed	zmike	D11088 efl/gesture: fix zoom to ignore single press events and not crash
Closed	zmike	D11087 efl/gesture: restrict flick and momentum gestures to original touch point
Closed	zmike	D11086 efl/gesture: handle multi-touch press for tap gestures

Diff 28832

View Options

src/lib/evas/gesture/efl_canvas_gesture_touch.c