If style is null, textblock style
is being created unneccessary. Patch fixes it.
Isn't the EINA_UNUSED wrong on the function argument Eo *obj ? Because the macro GET_REAL_PART_ON_FAIL_RETURN looks like this and it includes obj
#define GET_REAL_PART_ON_FAIL_RETURN(x) Edje_Real_Part *rp;\ Edje *ed;\ ed = _edje_fetch(obj);\ if ((!ed) || (!part)) return x;\ rp = _edje_real_part_recursive_get(&ed, part);\ if (!rp) return x;\
elementary_test fails for me without this patch with SEGFAULTS with the state of efl commit 509ad380832736361e01510991d27c67f8d10664:
./elementary_suite Running suite(s): Elementary_Init 100%: Checks: 1, Failures: 0, Errors: 0 Running suite(s): Elementary Running suite(s): Elementary 100%: Checks: 1, Failures: 0, Errors: 0 Running suite(s): Elementary 0%: Checks: 3, Failures: 0, Errors: 3 ../src/tests/elementary/elm_test_colorselector.c:9:E:elm_colorselector:elm_colorselector_legacy_type_check:0: (after this point) Received signal 11 (Segmentation fault) ../src/tests/elementary/elm_test_colorselector.c:29:E:elm_colorselector:elm_colorselector_palette:0: (after this point) Received signal 11 (Segmentation fault) ../src/tests/elementary/elm_test_colorselector.c:54:E:elm_colorselector:elm_atspi_role_get:0: (after this point) Received signal 11 (Segmentation fault)
ahhhrg, just running it in gdb gives me a bus error:
gdb ./elementary_suite GNU gdb (GDB; openSUSE Tumbleweed) 8.3.1 Copyright (C) 2019 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-suse-linux". Type "show configuration" for configuration details. For bug reporting instructions, please see: <http://bugs.opensuse.org/>. Find the GDB manual and other documentation resources online at: <http://www.gnu.org/software/gdb/documentation/>. For help, type "help". Type "apropos word" to search for commands related to "word"... Reading symbols from ./elementary_suite... (gdb) run Starting program: /media/media4/compile/e/efl/build/src/tests/elementary/elementary_suite Bus error (core dumped)