Page MenuHomePhabricator

eina: add eina_inarray_direct_accessor_new to directly access inarray member data without pointer indirection.
AbandonedPublic

Authored by cedric on Jan 24 2020, 11:28 AM.

Details

Summary

Depends on D11181

Diff Detail

Repository
rEFL core/efl
Branch
devs/cedric/model_children
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 15768
cedric created this revision.Jan 24 2020, 11:28 AM
segfaultxavi requested changes to this revision.Jan 27 2020, 1:47 AM

Minor doc comment.

src/lib/eina/eina_inarray.h
694

@p inarray -> @p array

This revision now requires changes to proceed.Jan 27 2020, 1:47 AM
cedric updated this revision to Diff 28639.Jan 29 2020, 10:33 AM

rebase and address comment

segfaultxavi resigned from this revision.Jan 29 2020, 10:49 AM

No more doc comments!

This will never be compatible with any usage in .eo, is that a good idea ?

This is I think the other way around or I miss understood eo. What do we expect from accessor<structure>?

if you have :accessor<Bla>

Bla *bla_ptr

eina_accessor_data_get(acc, &bla_ptr);

is the expected usage.

Ok, in that case, then I don't think this is a correct patch set. Is there documentation somewhere for this?

cedric abandoned this revision.Jan 30 2020, 4:29 PM