Details

Reviewers

CHAN
bu5hm4n

Commits

rEFL3612467c4fda: efl/gesture: avoid direct double access in structs

Summary

this is functionally wrong (the comparison fails) and also causes SIGBUS on
arm

Depends on D11197

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

zmike created this revision.Jan 27 2020, 6:28 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Jan 27 2020, 6:28 AM

Harbormaster completed remote builds in B15684: Diff 28530.Jan 27 2020, 6:29 AM

use intermediate double vals

Harbormaster completed remote builds in B15685: Diff 28531.Jan 27 2020, 7:08 AM

add a couple missing cases

zmike added a child revision: D11206: efl/gesture: ignore multi-touch end events in tap gesture recognizer.Jan 27 2020, 11:13 AM

Harbormaster completed remote builds in B15696: Diff 28545.Jan 27 2020, 11:15 AM

Looks good to me.

This revision is now accepted and ready to land.Jan 28 2020, 3:13 AM

These two things, then we are fine i think.

src/lib/evas/gesture/efl_canvas_gesture_recognizer_flick.c
267	Here as well.
315	Here as well.

This revision now requires changes to proceed.Jan 28 2020, 3:39 AM

add more cases

Harbormaster completed remote builds in B15731: Diff 28582.Jan 28 2020, 6:28 AM

rebase/rework

Harbormaster completed remote builds in B15810: Diff 28683.Jan 29 2020, 11:34 AM

That catched now all cases afaics.

This revision is now accepted and ready to land.Feb 3 2020, 7:18 AM

Closed by commit rEFL3612467c4fda: efl/gesture: avoid direct double access in structs (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyFeb 5 2020, 1:20 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/lib/evas/gesture/efl_canvas_gesture_recognizer_double_tap.c (6 lines)
M			src/lib/evas/gesture/efl_canvas_gesture_recognizer_flick.c (11 lines)
M			src/lib/evas/gesture/efl_canvas_gesture_recognizer_long_tap.c (6 lines)
M			src/lib/evas/gesture/efl_canvas_gesture_recognizer_triple_tap.c (6 lines)
M			src/lib/evas/gesture/efl_canvas_gesture_recognizer_zoom.c (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	28530	4359f42		Jan 27 2020, 6:28 AM	★	★
Diff 2	28531	4359f42	use intermediate double vals	Jan 27 2020, 7:07 AM	★	★
Diff 3	28545	a3bf99d	add a couple missing cases	Jan 27 2020, 11:13 AM	★	★
Diff 4	28582	5a35f36	add more cases	Jan 28 2020, 6:27 AM	★	★
Diff 5	28683	fb9d2f5	rebase/rework	Jan 29 2020, 11:22 AM	★	★
Diff 6	28843	17995ee	rEFL3612467c4fda7008eaa9c1b6a9d13983f5e75fc8	Feb 5 2020, 1:10 AM	★	★

efl/gesture: avoid direct double access in structs
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 28843

src/lib/evas/gesture/efl_canvas_gesture_recognizer_double_tap.c

src/lib/evas/gesture/efl_canvas_gesture_recognizer_flick.c

src/lib/evas/gesture/efl_canvas_gesture_recognizer_long_tap.c

src/lib/evas/gesture/efl_canvas_gesture_recognizer_triple_tap.c

src/lib/evas/gesture/efl_canvas_gesture_recognizer_zoom.c

efl/gesture: avoid direct double access in structsClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 28843

src/lib/evas/gesture/efl_canvas_gesture_recognizer_double_tap.c

src/lib/evas/gesture/efl_canvas_gesture_recognizer_flick.c

src/lib/evas/gesture/efl_canvas_gesture_recognizer_long_tap.c

src/lib/evas/gesture/efl_canvas_gesture_recognizer_triple_tap.c

src/lib/evas/gesture/efl_canvas_gesture_recognizer_zoom.c

efl/gesture: avoid direct double access in structs
ClosedPublic
Actions

Revision Contents
Changeset List