Details

Reviewers

SanghyeonLee
cedric

Diff Detail

Repository

rEFL core/efl

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 15746
Build 10724: arc lint + arc unit

felipealmeida created this revision.Jan 27 2020, 3:32 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

felipealmeida requested review of this revision.Jan 27 2020, 3:32 PM

Harbormaster completed remote builds in B15706: Diff 28556.Jan 27 2020, 3:32 PM

Added constrain for Layout_Base

Harbormaster completed remote builds in B15707: Diff 28557.Jan 27 2020, 5:02 PM

update patch with removing layoutFactory, and generic for all.
fill the doc comments but it need to be updated later.

Harbormaster completed remote builds in B15709: Diff 28559.Jan 27 2020, 8:47 PM

SanghyeonLee mentioned this in D11161: eolian_mono : rename ItemFactory<T> to GenericFactory<T>.Jan 27 2020, 8:49 PM

removing underline in GetPropBind and GetFactoryBind for complying mono naming rule.
virtual public to public virtual.
line indent fix.

Harbormaster completed remote builds in B15712: Diff 28563.Jan 27 2020, 10:12 PM

felipealmeida added a child revision: D11225: C#: Fix ambiguous calls to properties through extension methods.Jan 28 2020, 4:46 PM

add I for interface GenericFactoryExtended and GenericFactoryPartExtended.

Harbormaster completed remote builds in B15746: Diff 28598.Jan 28 2020, 6:22 PM

SanghyeonLee added reviewers: SanghyeonLee, cedric.Jan 30 2020, 7:35 PM

Hello SangHyeon,

since you updated the patch without comandeering I can't approve the patch.

		Path
M		src/bin/eolian_mono/eolian/mono/function_definition.hh (4 lines)
M		src/bin/eolian_mono/eolian/mono/part_definition.hh (8 lines)
M		src/bindings/mono/efl_mono/Bind.cs (6 lines)
A	M	src/bindings/mono/efl_mono/GenericFactory.cs (63 lines)
D	M	src/bindings/mono/efl_mono/ItemFactory.cs (32 lines)
M		src/bindings/mono/efl_mono/meson.build (2 lines)
M		src/tests/efl_mono/Model.cs (2 lines)
M		src/tests/efl_mono/Parts.cs (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	28556	5d982dd		Jan 27 2020, 3:32 PM	★	★
Diff 2	28557	5d982dd	Added constrain for Layout_Base	Jan 27 2020, 5:02 PM	★	★
Diff 3	28559	4ad0bec	update patch with removing layoutFactory, and generic for all.	Jan 27 2020, 8:46 PM	★	★
Diff 4	28563	4ad0bec	removing underline in GetPropBind and GetFactoryBind for complying mono naming…	Jan 27 2020, 10:12 PM	★	★
Diff 5	28598	0021853	add I for interface GenericFactoryExtended and GenericFactoryPartExtended.	Jan 28 2020, 6:22 PM	★	★

	Status	Author	Revision
	Needs Review	felipealmeida	D11225 C#: Fix ambiguous calls to properties through extension methods
	Needs Review	felipealmeida	D11211 C#: Create GenericFactory for non-layout objects

C#: Create GenericFactory for non-layout objects
Needs ReviewPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 28598

src/bin/eolian_mono/eolian/mono/function_definition.hh

src/bin/eolian_mono/eolian/mono/part_definition.hh

src/bindings/mono/efl_mono/Bind.cs

src/bindings/mono/efl_mono/GenericFactory.cs

src/bindings/mono/efl_mono/ItemFactory.cs

src/bindings/mono/efl_mono/meson.build

src/tests/efl_mono/Model.cs

src/tests/efl_mono/Parts.cs

C#: Create GenericFactory for non-layout objectsNeeds ReviewPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 28598

src/bin/eolian_mono/eolian/mono/function_definition.hh

src/bin/eolian_mono/eolian/mono/part_definition.hh

src/bindings/mono/efl_mono/Bind.cs

src/bindings/mono/efl_mono/GenericFactory.cs

src/bindings/mono/efl_mono/ItemFactory.cs

src/bindings/mono/efl_mono/meson.build

src/tests/efl_mono/Model.cs

src/tests/efl_mono/Parts.cs

C#: Create GenericFactory for non-layout objects
Needs ReviewPublic
Actions

Revision Contents
Changeset List