Page MenuHomePhabricator
Differential D11215

edje_entry: Fix to have event over item object.
Needs ReviewPublic
Actions

Authored by subodh6129 on Jan 28 2020, 2:53 AM.

Details

Reviewers
cedric
zmike
Summary

Suppose entry adds a button as item object
then button should take the event as well as
it should pass to underlying layer.
This patch fixes it.

@fix

Test Plan

Na

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15723
Build 10712: arc lint + arc unit
subodh6129 created this revision.Jan 28 2020, 2:53 AM
subodh6129 requested review of this revision.Jan 28 2020, 2:53 AM
zmike added a comment.Wed, Mar 18, 7:11 AM

Sorry for the delay.

Can you elaborate on the case where this is needed? Conceptually, it seems like if I click a button in an entry then only the button should be getting the event?

subodh6129 added a comment.Wed, Mar 18, 7:23 AM
In D11215#219874, @zmike wrote:

Sorry for the delay.

Can you elaborate on the case where this is needed? Conceptually, it seems like if I click a button in an entry then only the button should be getting the event?

Correct

zmike added a comment.Thu, Mar 19, 6:28 AM

But if you're setting repeat here then that means the button will get the event as well as the object below it inside the parent smart object?

subodh6129 added a comment.Thu, Mar 19, 6:30 AM
In D11215#220003, @zmike wrote:

But if you're setting repeat here then that means the button will get the event as well as the object below it inside the parent smart object?

It should pass to parent also

zmike added a comment.Thu, Mar 19, 6:32 AM

Okay, but I think that would be evas_object_propagate_events_set right?

Revision Contents
Changeset List

PathPackages
Msrc/lib/edje/edje_entry.c (2 lines)

Diff 28574

View Options

src/lib/edje/edje_entry.c

Loading...