efl/gesture: implement custom gesture recognizer framework
ClosedPublic
Actions

Authored by zmike on Jan 28 2020, 12:27 PM.

Details

Reviewers

bu5hm4n
CHAN
segfaultxavi

Commits

rEFLca2cc5915da8: efl/gesture: implement custom gesture recognizer framework

Summary

this adds support for creating custom (out of tree) gesture recognizers by
adding an abstract recognizer class that can be inherited and reused

docs TBA

Depends on D11222

Diff Detail

Repository

rEFL core/efl

Branch

master

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 15828

zmike created this revision.Jan 28 2020, 12:27 PM

Herald added subscribers: committers, reviewers, cedric. · View Herald TranscriptJan 28 2020, 12:27 PM

zmike requested review of this revision.Jan 28 2020, 12:27 PM

zmike added a child revision: D11224: tests/gesture: add custom recognizer test.

Harbormaster completed remote builds in B15743: Diff 28595.Jan 28 2020, 12:28 PM

Docs look alright, except minor typo.

Am I to assume that "Docs TBA" means that I should write them?
In this case, can you give me a summary of what a custom recognizer should do in finalize, add and recognize?
I can look at the example in the next patch, but I'd appreciate a bird's eye view description...

src/lib/evas/gesture/efl_canvas_gesture_events.eo
47	Typo: double `is`.

This revision now requires changes to proceed.Jan 29 2020, 12:34 AM

No, I meant I'd write docs for everything like I usually do and then you can doc cop on top of that.

rebase/rework

doc fix

Harbormaster completed remote builds in B15818: Diff 28691.Jan 29 2020, 11:34 AM

Harbormaster completed remote builds in B15828: Diff 28701.

Looks good to me.

segfaultxavi resigned from this revision.Jan 30 2020, 12:23 AM

This revision is now accepted and ready to land.Jan 30 2020, 12:23 AM

Closed by commit rEFLca2cc5915da8: efl/gesture: implement custom gesture recognizer framework (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyFeb 5 2020, 1:22 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
~		src/lib/evas/Efl_Canvas.h (2 lines)
~		src/lib/evas/Evas_Eo.h (2 lines)
A	M	src/lib/evas/gesture/efl_canvas_gesture_custom.c (38 lines)
A	M	src/lib/evas/gesture/efl_canvas_gesture_custom.eo (28 lines)
~		src/lib/evas/gesture/efl_canvas_gesture_events.eo (4 lines)
~		src/lib/evas/gesture/efl_canvas_gesture_manager.c (128 lines)
~		src/lib/evas/gesture/efl_canvas_gesture_private.h (14 lines)
A	M	src/lib/evas/gesture/efl_canvas_gesture_recognizer_custom.c (32 lines)
A	M	src/lib/evas/gesture/efl_canvas_gesture_recognizer_custom.eo (23 lines)
~		src/lib/evas/gesture/efl_canvas_gesture_recognizer_double_tap.c (2 lines)
~		src/lib/evas/gesture/efl_canvas_gesture_recognizer_flick.c (2 lines)
~		src/lib/evas/gesture/efl_canvas_gesture_recognizer_triple_tap.c (2 lines)
~		src/lib/evas/gesture/efl_canvas_gesture_recognizer_zoom.c (2 lines)
~		src/lib/evas/gesture/efl_canvas_gesture_types.eot (1 line)
~		src/lib/evas/gesture/meson.build (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	28595	0e13270		Jan 28 2020, 12:26 PM	★	★
Diff 2	28691	514af14	rebase/rework	Jan 29 2020, 11:23 AM	★	★
Diff 3	28701	514af14	doc fix	Jan 29 2020, 11:26 AM	★	★
Diff 4	28850	2c8d7aa	rEFLca2cc5915da861bbad97636a61d4e78c70a0365d	Feb 5 2020, 1:10 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
7e98d57cf9f4	6d656e1f6f8a	514af1450fa5	Mike Blumenkrantz	(Show More…)	Jan 28 2020, 10:52 AM

Status	Author	Revision
Abandoned	zmike	D11179 efl/gesture: remove recognizer::reset method
Closed	zmike	D11244 efl/gesture: remove unused manager function
Closed	zmike	D11243 evas/object: remove weird gesture manager method
Closed	zmike	D11242 efl/gesture: free object gesture list in destructor
Closed	zmike	D11241 efl/gesture: use array instead of list for garbage gesture objects
Closed	zmike	D11240 efl/gesture: fix gesture object cleanup when unregistering a recognizer
Closed	zmike	D11239 tests/gesture: add second custom recognizer test
Closed	zmike	D11238 tests/elm: add explicit printf for event cb assert failure
Closed	zmike	D11224 tests/gesture: add custom recognizer test
Closed	zmike	D11223 efl/gesture: implement custom gesture recognizer framework
Closed	zmike	D11222 efl/gesture: break out gesture processing code into separate function
Closed	zmike	D11221 efl/gesture: remove manager's recognizer_get method
Closed	zmike	D11220 tests/gesture: change random momentum cb to be useful momentum cb
Closed	zmike	D11209 tests/gesture: add a 10-touch tap test
Closed	zmike	D11208 efl/gesture: conditionally ignore multi-touch unpress events in zoom recognizer
Closed	zmike	D11207 efl/gesture: ignore successive press events in zoom recognizer when canceled
Closed	zmike	D11206 efl/gesture: ignore multi-touch end events in tap gesture recognizer
Closed	zmike	D11198 efl/gesture: avoid direct double access in structs
Closed	zmike	D11197 efl/gesture: reorder gesture private structs
Closed	zmike	D11178 efl/gesture: remove 'gesture' member from recognizer data struct
Closed	zmike	D11177 efl/gesture: remove 'manager' member from recognizer data struct
Closed	zmike	D11176 efl/gesture: remove 'config' property from recognizers
Closed	zmike	D11175 efl/gesture: expose 'continues' as a public property for recognizers
Closed	zmike	D11174 efl/gesture: add an event to notify when a config value has been changed
Closed	zmike	D11173 efl/gesture: move finger_size into private structs of recognizers
Closed	zmike	D11170 tests/gesture: add zoom and pinch tests
Closed	zmike	D11169 efl/gesture: discard non-press events for all touch points if unseen previously
Closed	zmike	D11168 efl/gesture: add 'pressed' state info for touch data
Closed	zmike	D11167 efl/gesture: correctly reset zoom gesture recognizer data on >2 finger touch
Closed	zmike	D11166 tests/elm: add util function for doing pinch motions
Closed	zmike	D11165 efl/gesture: more accurately handle flick/momentum recognition with multi-touch
Closed	zmike	D11164 efl/gesture: break out _direction_get() into helper function
Closed	zmike	D11163 evas/events: fix multi-touch object targeting on touch down events
Closed	zmike	D11155 efl/gesture: correct config value name for glayer_double_tap_timeout
Closed	zmike	D11145 tests/gesture: add extra event callback to verify event multiplication is fixed
Closed	zmike	D11144 efl/gesture: redo (and make stupider) hash usage in gesture manager
Closed	zmike	D11126 efl/gesture: add touch_count property for gesture event info
Closed	zmike	D11090 tests/gesture: add gesture tests for basic multi-touch tap events
Closed	zmike	D11089 tests/elm: add util functions for doing multi-touch events
Closed	zmike	D11088 efl/gesture: fix zoom to ignore single press events and not crash
Closed	zmike	D11087 efl/gesture: restrict flick and momentum gestures to original touch point
Closed	zmike	D11086 efl/gesture: handle multi-touch press for tap gestures