Page MenuHomePhabricator

efl_ui : re-introduce layout_factory
Needs RevisionPublic

Authored by SanghyeonLee on Jan 28 2020, 10:48 PM.

Details

Summary

Efl.Ui.Layout_Factory was renamed Generic_Factory on D11160.
now re-introduce layout_factory who inherit Generic_Factory with theme_config feature.
this class is to help layouting features on layout-based widget in factory creation.

Depends on D11160

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15750
Build 10728: arc lint + arc unit
SanghyeonLee created this revision.Jan 28 2020, 10:48 PM
SanghyeonLee requested review of this revision.Jan 28 2020, 10:48 PM
SanghyeonLee edited the summary of this revision. (Show Details)Jan 28 2020, 10:49 PM

I think we could add more layout helper method such like
efl_ui_layout_signal_signal_emit.

cedric requested changes to this revision.Jan 30 2020, 8:59 PM

This is kind of a weird series of patch, removing LayoutFactory and then readding it. I guess it allow for less code to write. Anyway, seeing the code like this now, it looks like we can do slightly better.

src/lib/elementary/efl_ui_layout_factory.c
37

Maybe only set the callback if klass or group or style is set?

This revision now requires changes to proceed.Jan 30 2020, 8:59 PM

sorry for late update,
we are so busy as the issues season comes again...

if you think it is weird I can make them in one combined patch or create new patch that only making generic_factory on top of layout factory..

src/lib/elementary/efl_ui_layout_factory.c
37

we already checked

if (pd->klass || pd->group || pd->style)

in constucting,
so you want to move it here?
I'm not sure which is better on the view of developper...
but... yes as we set the default item class,
so the callback is only necessary for the one who set the config...