Page MenuHomePhabricator

edje: Disable the json vector animation feature with a flag.
ClosedPublic

Authored by jsuya on Wed, Jan 29, 3:40 AM.

Details

Summary

Json vector animation requires the json loader to be loaded.
Therefore, if the loader does not load,
it prints an appropriate error message and disables the feature.

Depends on D11228

Test Plan

N/A

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jsuya created this revision.Wed, Jan 29, 3:40 AM
jsuya requested review of this revision.Wed, Jan 29, 3:40 AM
raster added a subscriber: raster.Wed, Jan 29, 4:32 AM

i don't see why the json support needs to be ifdefed out of edje_cc - people can compile edj files with vg/lottie support in them without special features needing to be in efl. they can't TEST/SEE it... but this i think is important for CI and other reasons to keep the support in edje_cc always - just runtime support should have it be blank and/or display errors when trying to load lottie vg parts... :)

jsuya updated this revision to Diff 28704.Wed, Jan 29, 11:49 PM

Update patch

  • Change edje_cc to compile vg part(json).
  • Add more error message.

thank you for review.

jsuya updated this revision to Diff 28705.Wed, Jan 29, 11:51 PM

minor fix..

jsuya updated this revision to Diff 29091.Mon, Feb 17, 12:29 AM

Update code
PLAY_BACK -> REWIND

Hermet accepted this revision.Mon, Feb 17, 1:56 AM
This revision is now accepted and ready to land.Mon, Feb 17, 1:56 AM
jsuya updated this revision to Diff 29095.Mon, Feb 17, 2:17 AM

fix typo

This revision was automatically updated to reflect the committed changes.