Page MenuHomePhabricator

efl/gesture: move manager's recognizer cleanup function to eo
ClosedPublic

Authored by zmike on Wed, Jan 29, 11:24 AM.

Details

Summary

this is needed by recognizers which use timers in order to do timeouts
on gestures

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Wed, Jan 29, 11:24 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Wed, Jan 29, 11:24 AM
segfaultxavi accepted this revision.Thu, Jan 30, 12:48 AM
segfaultxavi added a subscriber: segfaultxavi.

This is needed in EO for custom recognizers, right?

I see no problem doc- or API-wise (and there's not much to comment on, code-wise).

This revision is now accepted and ready to land.Thu, Jan 30, 12:48 AM
segfaultxavi requested changes to this revision.Thu, Jan 30, 2:10 AM
segfaultxavi added a reviewer: YOhoho.
segfaultxavi added a subscriber: YOhoho.

Actually, this patch fails to build with mono enabled.
The fix is:

--- a/src/bindings/mono/eo_mono/workaround.cs
+++ b/src/bindings/mono/eo_mono/workaround.cs
@@ -116,7 +116,7 @@ namespace Efl
 /// <para>Since EFL 1.22.</para>
 /// </summary>
 [StructLayout(LayoutKind.Sequential)]
-internal struct EventDescription
+public struct EventDescription
 {
     ///<summary>Name of the event.</summary>
     public IntPtr Name;

The structure Efl.EventDescription was initially public and was made internal in D10587 by @YOhoho. Why?

This revision now requires changes to proceed.Thu, Jan 30, 2:10 AM
zmike updated this revision to Diff 28706.Thu, Jan 30, 7:24 AM
zmike edited the summary of this revision. (Show Details)

remove event desc from use since we can get this internally

bu5hm4n accepted this revision.Mon, Feb 3, 11:30 PM
bu5hm4n added a subscriber: bu5hm4n.

Looks good i think.

zmike updated this revision to Diff 28891.Fri, Feb 7, 7:20 AM
zmike edited the summary of this revision. (Show Details)

rebase

This revision is now accepted and ready to land.Wed, Feb 12, 6:01 AM
Closed by commit rEFL0f2a61b5f280: efl/gesture: move manager's recognizer cleanup function to eo (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyFri, Feb 14, 12:22 AM
This revision was automatically updated to reflect the committed changes.