Make Get and Set methods internal for properties that get the
property syntax generated.
Details
Details
Diff Detail
Diff Detail
- Repository
- rEFL core/efl
- Branch
- master
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 15880
Comment Actions
It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/
Comment Actions
Please change commit message/summary to Make ... internal from Make ... protected.
| src/bin/eolian_mono/eolian/mono/property_definition.hh | ||
|---|---|---|
| 56 | Tuple property GetXXX, SetXXX are still public because getter/setter have different parameter directions. | |
| 76 | Some property have only getter with return value. (E.g. loop_count in efl_gfx_frame_controller.eo) | |
| 100 | If setter->explicit_return_type is bool or Eina_Error, its SetXXX Method can be internal, because they will be handled in proeprty setter. | |
Comment Actions
Made values comparations to be weaker so they can match getter and setter differences in directions.
Comment Actions
There's still a problem with efl_ui_win_wm_available_rotations_set_ptr which seems to be related with Tuples, but I still couldn't figure it out what exactly. @YOhoho if you can take a look and find a solution before my next shift that would probably be good for you guys. Error message is:
src/bindings/mono/efl_ui_win.eo.cs(1206,38): error CS0117: Efl.Ui.Win.NativeMethods' does not contain a definition for efl_ui_win_wm_available_rotations_set_ptr'
src/bindings/mono/efl_ui_win.eo.cs(3126,28): (Location of the symbol related to previous error)
src/bindings/mono/efl_ui_win.eo.cs(3189,21): error CS0103: The name `efl_ui_win_wm_available_rotations_set_static_delegate' does not exist in the current context
src/bindings/mono/efl_ui_win.eo.cs(3191,81): error CS0246: The type or namespace name `efl_ui_win_wm_available_rotations_set_delegate' could not be found. Are you missing an assembly reference?
src/bindings/mono/efl_ui_win.eo.cs(3191,21): error CS0103: The name `efl_ui_win_wm_available_rotations_set_static_delegate' does not exist in the current context
src/bindings/mono/efl_ui_win.eo.cs(3196,211): error CS0103: The name `efl_ui_win_wm_available_rotations_set_static_delegate' does not exist in the current context
Compilation failed: 5 error(s), 0 warnings
ninja: build stopped: subcommand failed.
| src/bin/eolian_mono/eolian/mono/property_definition.hh | ||
|---|---|---|
| 175 | Because of this line, efl_ui_win_wm_available_rotations_set_delegate is not generated. For wm_avaliable_rotations, has_wrapper_getter : 0, has_wrapper_setter : 1.
I'm not sure if this condition is necessary. | |