efl: add Cb suffix for callbacks
Needs ReviewPublic
Actions

Authored by YOhoho on Jan 31 2020, 2:34 AM.

Details

Reviewers

segfaultxavi
woohyun
SanghyeonLee
bu5hm4n
felipealmeida

Summary

Callbacks will be renamed to XXX.XXXXXX_Cb.
We don't have any EFL naming convention for callbacks. however, binding languages
have the naming guideline for framework.
This patch will make it esay to have a general translation rule for generator.

Diff Detail

Repository

rEFL core/efl

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 15872
Build 10757: arc lint + arc unit

YOhoho created this revision.Jan 31 2020, 2:34 AM

Herald added a project: efl. · View Herald TranscriptJan 31 2020, 2:34 AM

Herald added subscribers: committers, reviewers, cedric. · View Herald Transcript

Harbormaster completed remote builds in B15848: Diff 28742.Jan 31 2020, 2:34 AM

YOhoho requested review of this revision.Jan 31 2020, 2:34 AM

YOhoho added a child revision: D11256: eolian_mono: fix incorrect correct namespacing of EflLayoutSignalCb.

YOhoho added a reviewer: SanghyeonLee.Jan 31 2020, 2:36 AM

This makes sense to me, but I think not using underscores was the EO convention for callbacks. @cedric @zmike ?

segfaultxavi mentioned this in D11256: eolian_mono: fix incorrect correct namespacing of EflLayoutSignalCb.Jan 31 2020, 4:05 AM

On second thoughts, there is no naming convention, go ahead (builds and passes tests).

This revision is now accepted and ready to land.Jan 31 2020, 4:12 AM

C# recommends naming rules for callbacks.

https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/names-of-classes-structs-and-interfaces#names-of-common-types

Base Type	Derived/Implementing Type Guideline
System.Delegate	DO add the suffix "Callback" to names of delegates other than those used as event handlers.

I think it is better to add suffix like "Cb" for eo functions to apply same rules in eolian_mono.

I meant that there is no naming convention for callbacks in EO :)

I think it is better to add suffix like "Cb" for eo functions to apply same rules in eolian_mono.

Yeah, I think so too.

Mhm, would you mind also splitting the names with a "_" so "FooBar" gets "Foo_Bar" ? that would match the efl standard even more.

In D11255#213907, @bu5hm4n wrote:

Mhm, would you mind also splitting the names with a "_" so "FooBar" gets "Foo_Bar" ? that would match the efl standard even more.

Yes, i agree with that.

This comment has been deleted.

Rewrite patch.

Harbormaster completed remote builds in B15872: Diff 28776.Feb 2 2020, 11:25 PM

Revision Contents
Changeset List

			Path	Packages
M			src/lib/ecore/efl_appthread.c (8 lines)
M			src/lib/ecore/efl_filter_model.c (4 lines)
M			src/lib/ecore/efl_filter_model.eo (6 lines)
M			src/lib/ecore/efl_thread.c (20 lines)
M			src/lib/ecore/efl_threadio.eo (8 lines)
M			src/lib/eio/efl_io_manager.c (12 lines)
M			src/lib/eio/efl_io_manager.eo (16 lines)
M			src/lib/eio/efl_io_model.c (2 lines)
M			src/lib/eio/efl_io_model.eo (6 lines)
M			src/lib/eio/efl_io_model_private.h (2 lines)
M			src/lib/elementary/efl_ui_dnd.c (12 lines)
M			src/lib/elementary/efl_ui_dnd.eo (2 lines)
M			src/lib/elementary/efl_ui_dnd_container.eo (10 lines)
M			src/lib/elementary/efl_ui_dnd_types.eot (8 lines)
M			src/lib/elementary/efl_ui_position_manager_common.h (4 lines)
M			src/lib/elementary/efl_ui_position_manager_data_access_v1.eo (16 lines)
M			src/lib/elementary/efl_ui_position_manager_grid.c (2 lines)
M			src/lib/elementary/efl_ui_position_manager_list.c (2 lines)
M			src/lib/elementary/efl_ui_selection.c (2 lines)
M			src/lib/elementary/efl_ui_selection.eo (2 lines)
M			src/lib/elementary/efl_ui_selection_manager.c (28 lines)
M			src/lib/elementary/efl_ui_selection_manager.eo (14 lines)
M			src/lib/elementary/efl_ui_selection_manager_private.h (14 lines)
M			src/lib/elementary/efl_ui_selection_types.eot (2 lines)
M			src/lib/elementary/efl_ui_view_model.c (8 lines)
M			src/lib/elementary/efl_ui_view_model.eo (8 lines)
M			src/tests/eio/eio_test_manager.c (2 lines)