Page MenuHomePhabricator
Differential D11262

elm_config: add helper method for copying widget key bindings
ClosedPublic
Actions

Authored by bu5hm4n on Jan 31 2020, 5:58 AM.

Details

Reviewers
zmike
ali.alzyod
cedric
segfaultxavi
Commits
rEFL1587d7fa1bba: elm_config: add helper method for copying widget key bindings
Summary

Depends on D11261

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Jan 31 2020, 5:58 AM
bu5hm4n requested review of this revision.Jan 31 2020, 5:58 AM
bu5hm4n updated this revision to Diff 28756.Jan 31 2020, 6:31 AM

wrong condition

zmike added a comment.Jan 31 2020, 9:38 AM

This doesn't seem to be used anywhere?

bu5hm4n added a comment.Jan 31 2020, 9:39 AM

Yeah, it's a preparation for D11236, sorry

zmike accepted this revision.Jan 31 2020, 9:43 AM
This revision is now accepted and ready to land.Jan 31 2020, 9:43 AM
ali.alzyod added inline comments.Jan 31 2020, 10:56 PM
src/lib/elementary/elm_config.c
2317

Is not this function already update all missing bindings? why do we need to call _elm_key_bindings_copy_missing_bindings_of_widget for specific bindings after this call ?

Closed by commit rEFL1587d7fa1bba: elm_config: add helper method for copying widget key bindings (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyFeb 4 2020, 12:15 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/lib/elementary/elm_config.c (17 lines)

Diff 28791

View Options

src/lib/elementary/elm_config.c

Loading...