Page MenuHomePhabricator

efl_text_change_info: change text change type property( bool -> enum)
ClosedPublic

Authored by AbdullehGhujeh on Feb 3 2020, 1:47 AM.

Details

Summary

changed the insertion property to be an enum instead of a boolean property.
this will be clearer for usage and provide the ability to add more types in the future.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
AbdullehGhujeh created this revision.Feb 3 2020, 1:47 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

AbdullehGhujeh requested review of this revision.Feb 3 2020, 1:47 AM
AbdullehGhujeh edited the summary of this revision. (Show Details)Feb 3 2020, 1:49 AM
AbdullehGhujeh added reviewers: ali.alzyod, woohyun.
ali.alzyod added inline comments.Feb 3 2020, 1:51 AM
src/lib/efl/interfaces/efl_text_types.eot
13

this should be notated as @Beta for now

add beta tag

segfaultxavi accepted this revision.Feb 3 2020, 7:35 AM

Looks like a good idea, yeah. For clarity and extensibility.

This revision is now accepted and ready to land.Feb 3 2020, 7:35 AM
Closed by commit rEFL7c058d5e61b3: efl_text_change_info: change text change type property( bool -> enum) (authored by abdulleh Ghujeh <a.ghujeh@samsung.com>, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyFeb 4 2020, 12:56 AM
This revision was automatically updated to reflect the committed changes.