elm: add a logic to load modules for ui inspection
Needs RevisionPublic
Actions

Authored by akanad on Mon, Feb 3, 6:18 PM.

Details

Reviewers

JackDanielZ
Hermet
bu5hm4n

Summary

elm has a external ui inspection module named clouseau.
however there is a need for a kind of a infra which enables loading another module.
this patch add a logic to load multiple modules while initializing elementary.

Diff Detail

Repository

rEFL core/efl

Branch

arcpatch-D11276

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16073
Build 10841: arc lint + arc unit

akanad created this revision.Mon, Feb 3, 6:18 PM

Herald added a project: efl. · View Herald TranscriptMon, Feb 3, 6:18 PM

Herald added subscribers: committers, reviewers, cedric. · View Herald Transcript

akanad requested review of this revision.Mon, Feb 3, 6:18 PM

Harbormaster completed remote builds in B15878: Diff 28785.Mon, Feb 3, 6:18 PM

akanad added a reviewer: Hermet.Fri, Feb 7, 1:34 AM

bu5hm4n requested changes to this revision.Fri, Feb 7, 6:55 AM

bu5hm4n added a subscriber: bu5hm4n.

bu5hm4n added inline comments.

src/lib/elementary/elm_main.c
310	That should be static.
313	Why is this a seperated function? Its only called once.
330	The parameter should have void here.
333	This should support intree loading.
339	The parameter should have void here.
349	That is leaking memory.

This revision now requires changes to proceed.Fri, Feb 7, 6:55 AM

akanad marked 4 inline comments as done.Mon, Feb 10, 10:54 PM

akanad added inline comments.

src/lib/elementary/elm_main.c
313	I'd like to use another external ui-inspection tool rather than clouseau. this function will be utilized for it.
333	previous code returns in case of IN_TREE situation. I thought that you guys think that loading modules while building isn't necessary.

modify parameters
fix a leak stuff
add phab comments

Harbormaster completed remote builds in B15961: Diff 28939.Mon, Feb 10, 10:55 PM

rebasing
ping

Harbormaster completed remote builds in B16044: Diff 29082.Sun, Feb 16, 5:21 PM

I need to test that with closeau, which can take a bit.

rebase onto the latest

Harbormaster completed remote builds in B16073: Diff 29119.Tue, Feb 18, 6:24 PM

Have you tried checking if this module *ever* gets loaded ?

bu5hm4n requested changes to this revision.Wed, Feb 19, 7:09 AM

This revision now requires changes to proceed.Wed, Feb 19, 7:09 AM

My comment was probably a bit short:

That can NEVER EVER work. clouseau/api is not the name of the module you have added here.
Loading modules means, you have to add them to the config, means, whenever you want to debug your application you need to know which modules are running right now in order to overwrite the modules string correctly.

If you want to add a application that does the same as clouseau (btw. why not just extend / patch clouseau, that needs some love, but the same applies to a new application). However, if it *must* be a new application, then why not just call the file as well clouseau_debug? then the existing code will just work.

Revision Contents
Changeset List

		Path
M		src/lib/elementary/elm_main.c (96 lines)
A	M	src/modules/elementary/inspector_clouseau/meson.build (10 lines)
A	M	src/modules/elementary/inspector_clouseau/mod.c (99 lines)
M		src/modules/elementary/meson.build (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	28785	68d7f58		Mon, Feb 3, 6:18 PM	★	★
Diff 2	28939	68d7f58	* modify parameters	Mon, Feb 10, 10:55 PM	★	★
Diff 3	29082	0646de4	* rebasing	Sun, Feb 16, 5:21 PM	★	★
Diff 4	29119	df0715a	* rebase onto the latest	Tue, Feb 18, 6:24 PM	★	★