Page MenuHomePhabricator

C#: Add error checking for Eina.Success_Flag return type
ClosedPublic

Authored by felipealmeida on Tue, Feb 4, 3:39 PM.

Details

Summary

When a get and/or set from property is defined to return, explicitly,
a Eina.Success_Flag, the mono generator will check the return value
and generate an exception if the call fails.
Depends on D11252
Resolves T8383.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
felipealmeida created this revision.Tue, Feb 4, 3:39 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

felipealmeida requested review of this revision.Tue, Feb 4, 3:39 PM

I used char for the boolean type because this way we can change bool return types from .eo files without breaking ABI or C API compatibility.

I don't think we should allow bool to implicitly be checked.

jptiz updated this revision to Diff 28955.Tue, Feb 11, 9:46 AM
jptiz added a subscriber: jptiz.

Add managed name to exception message and simplify ifs.

jptiz updated this revision to Diff 28956.Tue, Feb 11, 9:48 AM

Fix mess with arc: considering only last commit, not the entire dependencies.

jptiz accepted this revision.Fri, Feb 14, 4:28 PM
This revision is now accepted and ready to land.Fri, Feb 14, 4:28 PM
This revision was automatically updated to reflect the committed changes.