It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

I think you misunderstood a bit what @segfaultxavi is pointing out. There should not be the "same" list of characters twice. It would be way better from a quality POV that both functions either use the same list of characters that are considered a whitespace, or simply iterate over the str and call _is_char_white on every character in the string. So we deduplicate this. And only have a single point of "we consider this whitespace".

Nice! The patch is getting smaller and smaller.

Now, regarding, _strchr_whitespace, it is still unclear to me why do you need such a complex method. Could something like this work?

// Returns first occurrence of whitespace character or NULL
static char*
_strchr_whitespace(const char* str)
{
   while (*str && !isspace(*str)) str++;
   if (*str) return str;
   return NULL;
}

In D11303#215153, @segfaultxavi wrote:

Nice! The patch is getting smaller and smaller.

Now, regarding, _strchr_whitespace, it is still unclear to me why do you need such a complex method. Could something like this work?

// Returns first occurrence of whitespace character or NULL
static char*
_strchr_whitespace(const char* str)
{
   while (*str && !isspace(*str)) str++;
   if (*str) return str;
   return NULL;
}

true %100