Page MenuHomePhabricator

efl_ui/image: implement efl.player::playback_loop property
ClosedPublic

Authored by zmike on Feb 10 2020, 9:13 AM.

Details

Summary

this enables the existing looping functionality only when playback_loop
is set (which is always set for legacy widgets)

fix T8589
Depends on D11307

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Feb 10 2020, 9:13 AM
zmike requested review of this revision.Feb 10 2020, 9:13 AM

Looks okayish to me, was the image before in a permanent playback loop ? I am wondering why we start now to null out the anim_timer now, and not before.

src/bin/elementary/test_photocam.c
156

This seems a bit unrelated ? Or should be part of the first commit ?

zmike added a comment.Wed, Mar 18, 6:50 AM

The timer pointer is nulled because having a dangling garbage pointer is bad.

src/bin/elementary/test_photocam.c
156

Uhh I think this is just handled by setting playback_loop or something. Either way it's probably fine

bu5hm4n accepted this revision.Fri, Mar 20, 7:44 AM

Okay, seems to make sense.

This revision is now accepted and ready to land.Fri, Mar 20, 7:44 AM
Closed by commit rEFL831d445cc01d: efl_ui/image: implement efl.player::playback_loop property (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyFri, Mar 20, 8:02 AM
This revision was automatically updated to reflect the committed changes.