Page MenuHomePhabricator

evas_textblock : remove wrong condition check for size_t value
ClosedPublic

Authored by SanghyeonLee on Feb 13 2020, 1:52 AM.

Details

Summary

pos in cursor handle is defined size_t type,
(see efl_canvas_textblock_internal.h)
which is unsigned int, and always bigger or equal to 0.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16004
Build 10808: arc lint + arc unit
SanghyeonLee created this revision.Feb 13 2020, 1:52 AM
SanghyeonLee requested review of this revision.Feb 13 2020, 1:52 AM
SanghyeonLee added a comment.EditedFeb 13 2020, 1:54 AM

@ali.alzyod ,
this code is reported in code verifying tool,
and I do not know what exactly you intended here.
is it okay to remove this line? or should it be non-zero checking?

ali.alzyod accepted this revision.Feb 13 2020, 3:10 AM

true :)

This revision is now accepted and ready to land.Feb 13 2020, 3:10 AM
This revision was automatically updated to reflect the committed changes.