Details
- Reviewers
bu5hm4n segfaultxavi - Commits
- rEFL798fdfbc70a8: efl/exe: add 'pid' property
Diff Detail
- Repository
- rEFL core/efl
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/
| src/lib/ecore/efl_exe.c | ||
|---|---|---|
| 586 | can you add #ifdef _WIN32 like line 593 ? it will be easier for me when i'll port efl_exe to Windows (i'll search for the _WIN32 occurences) | |
| src/lib/ecore/efl_exe.c | ||
|---|---|---|
| 586 | I think the pid is always a int, so it does not make sense to #ifdef this ? | |
| src/lib/ecore/efl_exe.c | ||
|---|---|---|
| 586 | no, DWORD (unsigned long int) : https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/ns-processthreadsapi-process_information | |
| src/lib/ecore/efl_exe.c | ||
|---|---|---|
| 586 | in _impl_ecore_exe_efl_object_finalize, this is just assigned to the int, so i think this will just work with windows how it is right now ? | |
| src/lib/ecore/efl_exe.eo | ||
| 60 | One super duper nitpick: Can you add here a remark,that -1 is always returned when you call that property before finalizer is executed, and the exe is actaully started. | |
| src/lib/ecore/efl_exe.c | ||
|---|---|---|
| 586 | though long is always the size of an int on Windows, just signedness | |
| src/lib/ecore/efl_exe.c | ||
|---|---|---|
| 586 | ok, let's hope that on Windows, the pid is not greater than 2 billions (i don't know if the pid is increased by one for each new process) | |
| src/lib/ecore/efl_exe.c | ||
|---|---|---|
| 586 | or we can create a type fo the PID, Efl_Exe_Pid or something like that | |