Page MenuHomePhabricator

evas_vg: modified the documentation and parameter names for the evas vector APIs
AbandonedPublic

Authored by herb on Mar 16 2020, 1:00 AM.

Details

Summary

refined the documentation, API name and parameters for evas vector APIs.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16319
Build 10935: arc lint + arc unit
herb created this revision.Mar 16 2020, 1:00 AM
herb requested review of this revision.Mar 16 2020, 1:00 AM
herb updated this revision to Diff 29500.Mar 16 2020, 1:09 AM

updated version for new evas enums

herb updated this revision to Diff 29501.Mar 16 2020, 1:16 AM

update tags

segfaultxavi requested changes to this revision.Mar 16 2020, 3:49 AM
segfaultxavi added subscribers: zmike, segfaultxavi.

Looks like you are defining new enums here that are already present in Eo files. Can you explain why?
I think @zmike worked on the move of this stuff from Legacy to Eo some time ago, it might be worth asking his opinion.

src/lib/evas/Evas_Legacy.h
3613

This is a Legacy file, why do you want to use an Eo *?

3729

The docs do not match the enums!
Please take a look at src/static_libs/freetype/sw_ft_stroker.h:42

3838

Eo* ?
Lots of other APIs below make the opposite change.

4015

It should be:

@param[in] obj The object.
4536

Shouldn't this be updated to use the Legacy version?

This revision now requires changes to proceed.Mar 16 2020, 3:49 AM
herb added a comment.EditedMar 16 2020, 4:37 AM

@segfaultxvai
hello, thanks for the comment, I will divide this patch for readability(D11513 is the first path of this)
Evas_Vg_Join enum values refers to src/lib/efl/interfaces/efl_gfx_types.eot:71(Efl.Gfx.Join)
and in case of other comments, I will change to follow your comments.

Looks like you are defining new enums here that are already present in Eo files. Can you explain why?

=> because I think legacy APIs should use legacy enum values, so I defined evas enum types
ex) for hiding gfx enums
evas_vg_shape_path_set(Evas_Vg_Shape *obj, const Evas_Vg_Path_Command *op, const double *points)
evas_vg_shape_stroke_dash_get(Evas_Vg_Shape *obj, const Evas_Vg_Dash **dash, unsigned int *length)
evas_vg_gradient_stop_set(Evas_Vg_Gradient *obj, const Evas_Vg_Gradient_Stop *colors, unsigned int length)
evas_vg_shape_stroke_dash_set(Eo *obj, const Evas_Vg_Dash *dash, unsigned int length)

I think @zmike worked on the move of this stuff from Legacy to Eo some time ago, it might be worth asking his opinion.

herb abandoned this revision.Mar 16 2020, 7:54 PM

This revision is divided into D11517, D11518, D11519

src/lib/evas/Evas_Legacy.h
3729

This enum values refers to src/lib/efl/interfaces/efl_gfx_types.eot:71(Efl.Gfx.Join)