Differential D11527

ecore/audio: free vio on in/out object destruction
ClosedPublic
Actions

Authored by zmike on Mar 17 2020, 9:10 AM.

Tags

Subscribers

cedric, reviewers, committers

Details

Reviewers

Commits

rEFLc697965a8c72: ecore/audio: free vio on in/out object destruction

Summary

ensure we don't leak these since that means we also leak the user's free
data and callback

Depends on D11526

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

zmike created this revision.Mar 17 2020, 9:10 AM

Herald added subscribers: committers, reviewers, cedric. · View Herald TranscriptMar 17 2020, 9:10 AM

zmike requested review of this revision.Mar 17 2020, 9:10 AM

zmike added a child revision: D11528: ecore/audio: add a couple more functions to the pulse callback struct.

Harbormaster completed remote builds in B16345: Diff 29543.Mar 17 2020, 9:19 AM

bu5hm4n requested changes to this revision.Mar 23 2020, 11:20 AM

bu5hm4n added inline comments.

src/lib/ecore_audio/ecore_audio_obj_in.c
192–195	Can you add { and } here ? clang analyzer complains here, and i already see coverity complaining about it.

This revision now requires changes to proceed.Mar 23 2020, 11:20 AM

add braces

Harbormaster completed remote builds in B16390: Diff 29618.Mar 23 2020, 12:01 PM

Thank you

This revision is now accepted and ready to land.Mar 23 2020, 12:06 PM

Closed by commit rEFLc697965a8c72: ecore/audio: free vio on in/out object destruction (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyMar 25 2020, 2:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/lib/ecore_audio/ecore_audio_obj_in.c (8 lines)
M			src/lib/ecore_audio/ecore_audio_obj_out.c (4 lines)

Diff 29698

src/lib/ecore_audio/ecore_audio_obj_in.c

Loading...

src/lib/ecore_audio/ecore_audio_obj_out.c

Loading...