Page MenuHomePhabricator

evas/text: remove paragraph_direction inherit during render
ClosedPublic

Authored by zmike on Mar 20 2020, 8:30 AM.

Details

Summary

this is unnecessary:

  • for the text object itself, the value is correctly set whenever the paragraph_direction property is changed
  • for inheritance, smart object already implements propagation which triggers on member add or property change

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Mar 20 2020, 8:30 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Mar 20 2020, 8:30 AM
bu5hm4n accepted this revision.Apr 3 2020, 5:36 AM
This revision is now accepted and ready to land.Apr 3 2020, 5:36 AM

Thank you, this removes a lot of unnessessary function calls during scrolling in elm_test

Closed by commit rEFL6fb79af116a7: evas/text: remove paragraph_direction inherit during render (authored by zmike, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyApr 3 2020, 5:41 AM
This revision was automatically updated to reflect the committed changes.