Page MenuHomePhabricator

efl_ui_widget: fix disabled set behaviour
ClosedPublic

Authored by bu5hm4n on Mar 23 2020, 3:00 AM.

Details

Summary

this fixes disabled set behaviour. This ensures that when setting
disabled twice, that unsetting it once does not break the overall state.

This never appeared in any real life example, because
elm_object_disabled_set is already checking for equalness. However, this
is not wanted here, because the simple setter can also be used to sync
the state with the parent, which appears to be helpfull.

Depends on D11550

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Mar 23 2020, 3:00 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

bu5hm4n requested review of this revision.Mar 23 2020, 3:00 AM
zmike requested changes to this revision.Mar 23 2020, 7:14 AM
zmike added a subscriber: zmike.
zmike added inline comments.
src/tests/elementary/efl_ui_test_widget.c
380

Too many printfs.

This revision now requires changes to proceed.Mar 23 2020, 7:14 AM
bu5hm4n updated this revision to Diff 29605.Mar 23 2020, 9:00 AM
bu5hm4n edited the summary of this revision. (Show Details)

remove stray printfs

zmike accepted this revision.Mar 23 2020, 9:09 AM
This revision is now accepted and ready to land.Mar 23 2020, 9:09 AM
Closed by commit rEFL151862f50cac: efl_ui_widget: fix disabled set behaviour (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by zmike). · Explain WhyMar 23 2020, 9:12 AM
This revision was automatically updated to reflect the committed changes.