Page MenuHomePhabricator

canvas 3d: remove all canvas3d features across efl.
ClosedPublic

Authored by Hermet on Mar 23 2020, 3:48 AM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Hermet created this revision.Mar 23 2020, 3:48 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

Hermet requested review of this revision.Mar 23 2020, 3:48 AM
Hermet updated this revision to Diff 29601.Mar 23 2020, 3:52 AM

updated

Hermet updated this revision to Diff 29602.Mar 23 2020, 3:58 AM

removed proxy_textures

bu5hm4n requested changes to this revision.Mar 23 2020, 11:02 AM
../src/lib/evas/canvas/evas_object_main.c:16:15: warning: initialization of ‘int’ from ‘void *’ makes integer from pointer without a cast [-Wint-conversion]
   16 |   NULL, NULL, NULL, 0, 0, NULL, 0, 0, 0, 0
      |               ^~~~
../src/lib/evas/canvas/evas_object_main.c:16:15: note: (near initialization for ‘default_proxy.w’)
../src/lib/evas/canvas/evas_object_main.c:16:27: warning: initialization of ‘unsigned char:1’ from ‘void *’ makes integer from pointer without a cast [-Wint-conversion]
   16 |   NULL, NULL, NULL, 0, 0, NULL, 0, 0, 0, 0
      |                           ^~~~
../src/lib/evas/canvas/evas_object_main.c:16:27: note: (near initialization for ‘default_proxy.redraw’)
../src/lib/evas/canvas/evas_object_main.c:16:42: warning: excess elements in struct initializer
   16 |   NULL, NULL, NULL, 0, 0, NULL, 0, 0, 0, 0
      |                                          ^

Looks good, except for this warning.

This revision now requires changes to proceed.Mar 23 2020, 11:02 AM
Hermet updated this revision to Diff 29622.Mar 23 2020, 6:23 PM

removed null initializing pointer.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 25 2020, 3:20 AM
This revision was automatically updated to reflect the committed changes.