Page MenuHomePhabricator

Wallpaper/Theme Selector - add button for online themes/wallpapers using extra (extra.e.org)
ClosedPublic

Authored by jf_simon on Tue, Mar 24, 3:19 AM.

Diff Detail

Repository
rE core/enlightenment
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jf_simon created this revision.Tue, Mar 24, 3:19 AM
jf_simon requested review of this revision.Tue, Mar 24, 3:19 AM
jf_simon edited the summary of this revision. (Show Details)Tue, Mar 24, 5:47 AM
devilhorns resigned from this revision.Tue, Mar 24, 5:58 AM
raster requested changes to this revision.Wed, Mar 25, 9:25 AM
raster added a subscriber: raster.
raster added inline comments.
src/modules/conf_theme/e_int_config_theme.c
521

in launch do what connman module does like:

Efreet_Desktop *desktop;
E_Zone *zone;

desktop = efreet_util_desktop_file_id_find("econnman.desktop");
if (!desktop)
  {
     e_util_dialog_internal
       (_("Missing Application"),
       _("This module wants to execute an external application "
         "EConnMan that does not exist.<ps/>"
         "Please install <b>EConnMan</b> application."));
     return;
  }

zone = e_gadcon_client_zone_get(inst->gcc);
if (!zone)
  zone = e_zone_current_get();

e_exec(zone, desktop, NULL, NULL, "econnman/app");
efreet_desktop_free(desktop);
770

could you add code to only add this button if extra is found? e.g. what connman module does with:

if (efreet_util_desktop_file_id_find("econnman.desktop"))
  {
     bt = e_widget_button_add(evas, _("Configure"), NULL,
                              _econnman_configure_cb, inst, NULL);
     e_widget_list_object_append(list, bt, 1, 0, 0.5);
  }
src/modules/conf_theme/e_int_config_wallpaper.c
310

same here as above....

495

same as above...

This revision now requires changes to proceed.Wed, Mar 25, 9:25 AM
jf_simon added inline comments.Wed, Mar 25, 1:21 PM
src/modules/conf_theme/e_int_config_theme.c
521

ok, then i take your code. Thank you

770

i prefer to let the button visible with the hint to extra. better inform a user about a feature, instead hiding it.

i don't think we want to encourage installing extra ... we want this to work out of the box without it installed. but i thought that was asking too much... :) so as a simple patch to support extra for now - sure. but long term this should just work with no extra dependencies or installs like screenshot sharing just works with nothing extra installed.

Overall I like this idea :-)

actually i don't just want consumption working ... when i said sharing... i mean also users being able to share. if they are making a theme of their own - select it and then press/select share and presto - it gets shared. this will require a lot more work on extra or on something new that allows uploads like shot but probably needs some QA cycle and approval to become visible to other user first. but before themes - sharing wallpapers would be a fantastic first step. i suspect that whatever we end up having will look vastly different to the current extra implementation.

jf_simon updated this revision to Diff 29747.Sat, Mar 28, 6:44 AM
jf_simon edited the summary of this revision. (Show Details)
raster accepted this revision.Sun, Mar 29, 3:11 AM
This revision is now accepted and ready to land.Sun, Mar 29, 3:11 AM
This revision was automatically updated to reflect the committed changes.