Differential D11565

fix segfault when there is no text in clipboard
ClosedPublic
Actions

Authored by vtorri on Mar 24 2020, 7:13 AM.

Tags

Subscribers

cedric, reviewers, committers

Details

Reviewers

Commits

rEFLe0f5e80f7831: fix segfault when there is no text in clipboard

Test Plan

cnp a clipboard content without text

Diff Detail

Repository

Branch

vtorri_cnp_fix

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16412
Build 10976: arc lint + arc unit

vtorri created this revision.Mar 24 2020, 7:13 AM

Herald added a project: efl. · View Herald TranscriptMar 24 2020, 7:13 AM

Herald added subscribers: committers, reviewers, cedric. · View Herald Transcript

Harbormaster completed remote builds in B16398: Diff 29635.Mar 24 2020, 7:13 AM

vtorri requested review of this revision.Mar 24 2020, 7:13 AM

zmike requested changes to this revision.Mar 24 2020, 7:24 AM

zmike added inline comments.

src/modules/ecore_evas/engines/win32/ecore_evas_win32.c
1301	Seems like this leaks `data`?

This revision now requires changes to proceed.Mar 24 2020, 7:24 AM

also there too, then :
https://git.enlightenment.org/core/efl.git/tree/src/modules/ecore_evas/engines/cocoa/ecore_evas_cocoa.c#n521

in wayland too i think

fix leak

vtorri marked an inline comment as done.Mar 24 2020, 7:46 AM

Harbormaster completed remote builds in B16412: Diff 29649.Mar 24 2020, 7:52 AM

zmike accepted this revision.Mar 26 2020, 7:34 AM

This revision is now accepted and ready to land.Mar 26 2020, 7:34 AM

Only cocoa exhibits the same issue.

Closed by commit rEFLe0f5e80f7831: fix segfault when there is no text in clipboard (authored by vtorri, committed by zmike). · Explain WhyMar 26 2020, 7:47 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/modules/ecore_evas/engines/win32/ecore_evas_win32.c (30 lines)

Diff 29649

src/modules/ecore_evas/engines/win32/ecore_evas_win32.c

Loading...