Page MenuHomePhabricator
Differential D11591

eo: there is no reason to equip for calls to classes
ClosedPublic
Actions

Authored by bu5hm4n on Mar 25 2020, 2:19 AM.

Details

Reviewers
zmike
stefan_schmidt
raster
Commits
rEFL790a63c15f92: eo: there is no reason to equip for calls to classes
Summary

calls to classes are not needed anymore, since class inheritance is not
a thing anymore. After removing is_obj from the function the compile can
optimize the code better, since assignments to fields are not
conditionally anymore.

Diff Detail

Repository
rEFL core/efl
Branch
devs/bu5hm4n/eo_work
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 16426
bu5hm4n created this revision.Mar 25 2020, 2:19 AM
bu5hm4n requested review of this revision.Mar 25 2020, 2:19 AM
bu5hm4n added a child revision: D11592: eo: move all call assignment.
stefan_schmidt accepted this revision.Mar 26 2020, 5:29 AM

I have not much confidence in myself when it comes to eo. The re-flow of the code without is_obj looks correct to me, though.

Please someone with more eo knowledge give another approval here. :-)

This revision is now accepted and ready to land.Mar 26 2020, 5:29 AM
raster accepted this revision.Mar 26 2020, 5:38 AM
Closed by commit rEFL790a63c15f92: eo: there is no reason to equip for calls to classes (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyMar 26 2020, 5:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
~src/lib/eo/eo.c (64 lines)

Diff 29677

View Options

src/lib/eo/eo.c

Loading...