eo: move all call assignment
ClosedPublic
Actions

Authored by bu5hm4n on Mar 25 2020, 2:19 AM.

Details

Reviewers

Commits

rEFL8e20d28dfe63: eo: move all call assignment

Summary

this improves the cache performance a lot. Caches are only invalidated
once, and not multiple times.
Depends on D11591

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

bu5hm4n requested review of this revision.Mar 25 2020, 2:19 AM

This looks fine to me, but I wonder how are you measuring the cache hits and misses?

This revision is now accepted and ready to land.Mar 26 2020, 5:38 AM

@stefan_schmidt, these numbers are messured with perf stat -e cache-misses elementary_perf.

Closed by commit rEFL8e20d28dfe63: eo: move all call assignment (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyMar 26 2020, 5:59 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/lib/eo/eo.c (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	29678	7750964		Mar 25 2020, 2:19 AM	★	★
Diff 2	29716	790a63c	rEFL8e20d28dfe63370423b240565c3487e5281735c2	Mar 26 2020, 5:58 AM	★	★

Status	Author	Revision
Closed	bu5hm4n	D11593 eo: use eina_prefetch
Closed	bu5hm4n	D11592 eo: move all call assignment
Closed	bu5hm4n	D11591 eo: there is no reason to equip for calls to classes