Page MenuHomePhabricator

evas_textblock_tests: do not free a text cursor here
ClosedPublic

Authored by bu5hm4n on Mar 25 2020, 2:40 AM.

Details

Summary

the cur_obj would have been always dead at this point, as the textblock
was freed. This now moved the textcursor object to a previous point.
However, we could also remove the explicit cursor deletion...
Depends on D11595

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Mar 25 2020, 2:40 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

bu5hm4n requested review of this revision.Mar 25 2020, 2:40 AM
zmike accepted this revision.Mar 25 2020, 6:30 AM
zmike added a subscriber: zmike.

It always confused me why we're bothering to explicitly delete these objects given that the canvas is being deleted, but I guess if we're finding bugs doing it...

This revision is now accepted and ready to land.Mar 25 2020, 6:30 AM
Closed by commit rEFLa4d76984921e: evas_textblock_tests: do not free a text cursor here (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyMar 25 2020, 2:19 PM
This revision was automatically updated to reflect the committed changes.