Page MenuHomePhabricator

evas_textblock: prevent updating cursor unless they are ready during markup_set
ClosedPublic

Authored by ali.alzyod on Mar 25 2020, 5:08 AM.

Details

Summary

During Markup_set at text block level, we will not update the cursors, unless their status is updated and ready.

This can cause serious issues, especially if a cursor also depends on another cursor for some calculations, (like the segfault happening in TextBox T8637)

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16442
Build 10980: arc lint + arc unit
ali.alzyod created this revision.Mar 25 2020, 5:08 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Mar 25 2020, 5:08 AM
ali.alzyod edited the summary of this revision. (Show Details)Mar 25 2020, 5:11 AM
ali.alzyod added reviewers: woohyun, bu5hm4n.
ali.alzyod updated this revision to Diff 29688.Mar 25 2020, 5:52 AM

update test case to produce the issue

ali.alzyod updated this revision to Diff 29710.Mar 25 2020, 9:12 PM

change the logic at evas_textblock level

ali.alzyod retitled this revision from efl.ui.textbox: prevent updating selection internally on markup/text set to evas_textblock: prevent updating cursor unless they are ready during markup_set.Mar 25 2020, 9:20 PM
ali.alzyod edited the summary of this revision. (Show Details)
ali.alzyod added a reviewer: zmike.
woohyun accepted this revision.Mar 25 2020, 10:42 PM

This looks proper to fix the issue case. Thanks.

This revision is now accepted and ready to land.Mar 25 2020, 10:42 PM
This revision was automatically updated to reflect the committed changes.