Page MenuHomePhabricator

eina: prefetch for _eo_obj_pointer_get
ClosedPublic

Authored by bu5hm4n on Mar 26 2020, 3:45 AM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Mar 26 2020, 3:45 AM
bu5hm4n requested review of this revision.Mar 26 2020, 3:45 AM
stefan_schmidt added inline comments.Mar 26 2020, 5:31 AM
src/lib/eo/eo_ptr_indirection.c
107

The line number in the comment (and all the other ones) will bit rot any moment. Don't think they are worth putting in. Maybe more confusing actually once they point to the wrong line.
Do we really need to comment for what line the PREFETCH is supposed to be?

raster requested changes to this revision.Mar 26 2020, 5:41 AM
raster added inline comments.
src/lib/eo/eo_ptr_indirection.c
109

this could be simpler and just do

EINA_PREFETCH_NOCACHE(TABLE_FROM_IDS);

couldn't it?

149

this could be simpler and just do

EINA_PREFETCH_NOCACHE(TABLE_FROM_IDS);

couldn't it?

This revision now requires changes to proceed.Mar 26 2020, 5:41 AM
bu5hm4n added inline comments.Mar 26 2020, 5:51 AM
src/lib/eo/eo_ptr_indirection.c
107

I really think we should keep these comments here, before it was not really obvious for which line the prefetch is. It could be for line 119 or line 121.

109

Mhm, no. This would need a "&" in the beginning, and then i am not sure if the compiler wouldn't just derefence it, and prefetch that address, which is not the point of this prefetch.

This revision was not accepted when it landed; it landed in state Needs Revision.Mar 26 2020, 10:08 AM
Closed by commit rEFL1b39c772eaa6: eina: prefetch for _eo_obj_pointer_get (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by raster). · Explain Why
This revision was automatically updated to reflect the committed changes.