Page MenuHomePhabricator

elm_entry: using keycode for main keyboard shortcuts
ClosedPublic

Authored by ali.alzyod on Mar 26 2020, 11:07 PM.

Details

Summary

Previously we use key strings to detect keyboard shortcuts (for example copy/paste/select_all, .. etc)
Now we will use key code alongside with these key strings (I do not remove the key string, because I am afraid something depends on them because some methods do not send keycode with keys)

This issue can be easily detected when the keyboard layout is not a Latin language, for example Hitting "C" will produce key string depends on related language not letter C, but Keycodes remain the same regardless of keyboard layout.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ali.alzyod created this revision.Mar 26 2020, 11:07 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ali.alzyod requested review of this revision.Mar 26 2020, 11:07 PM
ali.alzyod edited the summary of this revision. (Show Details)Mar 26 2020, 11:09 PM
bu5hm4n requested changes to this revision.Apr 3 2020, 5:23 AM

Looks good otherwise.

(I am now checking why they arent causing errors)

src/tests/elementary/elm_test_entry.c
597

can you remove these arguments, i am not sure why they arent erroing in compilation, win_add is a void function...

This revision now requires changes to proceed.Apr 3 2020, 5:23 AM

okay, we have that all over the place, the definition does not state "no arguments" .-.

bu5hm4n accepted this revision.Apr 3 2020, 5:24 AM
This revision is now accepted and ready to land.Apr 3 2020, 5:24 AM
Closed by commit rEFLd7d948c23d19: elm_entry: using keycode for main keyboard shortcuts (authored by ali.alzyod, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyApr 3 2020, 5:41 AM
This revision was automatically updated to reflect the committed changes.