elm/hoversel: reduce sizing_eval calcs
Needs ReviewPublic
Actions

Authored by zmike on Apr 3 2020, 8:52 AM.

Details

Reviewers: None

Summary

this doesn't need to be emitting signals or recalculating the box on
every sizing eval; signals are emitted naturally during the eval, and
the box (and its items) can be calculated only during activation since there
will be no post-activation changes there, as hoversel lacks a group_calc
implementation to handle such things anyway
Depends on D11644

Diff Detail

Repository

rEFL core/efl

Branch

master

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 16506

zmike created this revision.Apr 3 2020, 8:52 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested review of this revision.Apr 3 2020, 8:52 AM

zmike added a child revision: D11646: elm/hoversel: force calc on internal hover object during activate.

Harbormaster completed remote builds in B16506: Diff 29821.Apr 3 2020, 8:57 AM

I am on the edge here if I consider this a fix we can still apply for 1.24 or if we should wait until after the release.
To often I have seen these calcs being necessary due to other hidden bugs we had.

Code in fine on a review but I am unsure when to apply.

I don't think it's urgent.

Revision Contents
Changeset List

			Path	Packages
~			src/lib/elementary/elc_hoversel.c (17 lines)

Commit	Tree	Parents	Author	Summary	Date
656069d6d6d7	7604b83f81d3	5e142b6634d7	Mike Blumenkrantz	(Show More…)	Apr 3 2020, 8:32 AM

Status	Author	Revision
Closed	zmike	D11704 tests/elm: explicitly destroy hoversel while active
Closed	zmike	D11647 tests/elm: add hoversel test to verify edge of canvas positioning
Closed	zmike	D11646 elm/hoversel: force calc on internal hover object during activate
Needs Review	zmike	D11645 elm/hoversel: reduce sizing_eval calcs
Closed	zmike	D11644 tests/elm: add hoversel behavior tests
Closed	zmike	D11643 elm/hoversel: remove unnecessary internal callback deletion
Closed	zmike	D11642 elm/hoversel: use a wref to accurately track internal hover object

Diff 29821

View Options

src/lib/elementary/elc_hoversel.c

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	29821	5e142b6		Apr 3 2020, 8:52 AM	★	★