Page MenuHomePhabricator

elm/hoversel: reduce sizing_eval calcs
Needs ReviewPublic

Authored by zmike on Apr 3 2020, 8:52 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

this doesn't need to be emitting signals or recalculating the box on
every sizing eval; signals are emitted naturally during the eval, and
the box (and its items) can be calculated only during activation since there
will be no post-activation changes there, as hoversel lacks a group_calc
implementation to handle such things anyway
Depends on D11644

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 16506
zmike created this revision.Apr 3 2020, 8:52 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

I am on the edge here if I consider this a fix we can still apply for 1.24 or if we should wait until after the release.
To often I have seen these calcs being necessary due to other hidden bugs we had.

Code in fine on a review but I am unsure when to apply.

zmike added a comment.Apr 16 2020, 6:14 AM

I don't think it's urgent.