Page MenuHomePhabricator

edje: fix cursor scrolling
ClosedPublic

Authored by bowonryu on Apr 5 2020, 11:40 PM.

Details

Summary

If there is a string larger than the size of entry
and when the entry is auto scrolling, cursor is not visible.
Using _edje_entry_cursor_geometry_get guarantees the minimum size of the cursor,
and guarantee the size from edje. (min_restricted_calc)

Test Plan

elemenary_test

Enter a long string in the "Search Menu" entry.
Observe the cursor when the entry scrolls automatically.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16510
Build 11003: arc lint + arc unit
bowonryu created this revision.Apr 5 2020, 11:40 PM
bowonryu requested review of this revision.Apr 5 2020, 11:40 PM
ali.alzyod accepted this revision.Apr 6 2020, 11:59 PM

Pass the test, and fix the issue

This revision is now accepted and ready to land.Apr 6 2020, 11:59 PM

I am tyring to reproduce the issue here. How long is long for the text input? I have been entering a lot of text and was able to see the scroller also when scrolling.

I am tyring to reproduce the issue here. How long is long for the text input? I have been entering a lot of text and was able to see the scroller also when scrolling.

Hmm, this is not what I am seeing. Even when reaching the end of the input entry the cursor shows fine for me even without this patch.

Testing with the patch applied did not make any visual change to me compared to run it without the patch.

But if you both see the issue and it get fixed with this patch I am not going to block it.

This revision was automatically updated to reflect the committed changes.