Page MenuHomePhabricator

elm_entry, accessibility: Send utf8 text instead of markup to ATSPI client
ClosedPublic

Authored by shilpasingh on Apr 6 2020, 8:22 AM.

Details

Summary

Markup text cannot be read as per expectation by a text to speech engine, hence send text
in UTF8 format

Test Plan

Test the text returned by connecting to object:text-changed:insert and object:text-changed:delete events in ATSPI-clients

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16523
Build 11006: arc lint + arc unit
shilpasingh created this revision.Apr 6 2020, 8:22 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

shilpasingh requested review of this revision.Apr 6 2020, 8:22 AM
shilpasingh retitled this revision from elm_entry, accessibility: Send utf8 text instead of markup to elm_entry, accessibility: Send utf8 text instead of markup to ATSPI client.Apr 6 2020, 8:26 AM
shilpasingh edited the summary of this revision. (Show Details)
shilpasingh edited the test plan for this revision. (Show Details)
shilpasingh added a reviewer: kimcinoo.
kimcinoo accepted this revision.Apr 6 2020, 6:09 PM
This revision is now accepted and ready to land.Apr 6 2020, 6:09 PM
kimcinoo requested changes to this revision.Apr 6 2020, 6:16 PM

Please find inline comment.

src/lib/elementary/elm_entry.c
2251

It seems that variable text is not necessary.

2266

How about following lines instead of using text variable?

atspi_info.content = elm_entry_markup_to_utf8(edje_info->change.insert.content);
...
free(atspi_info.content)

2274

Same here.

This revision now requires changes to proceed.Apr 6 2020, 6:16 PM
shilpasingh updated this revision to Diff 29857.Apr 7 2020, 4:14 AM

Fixed review comments

shilpasingh updated this revision to Diff 29858.Apr 7 2020, 4:18 AM
shilpasingh marked 3 inline comments as done.

Fixed formatting issues

Fixed comments

This revision was not accepted when it landed; it landed in state Needs Review.Apr 7 2020, 4:24 AM
This revision was automatically updated to reflect the committed changes.
kimcinoo reopened this revision.Apr 7 2020, 4:50 AM
kimcinoo accepted this revision.
This revision is now accepted and ready to land.Apr 7 2020, 4:50 AM
kimcinoo closed this revision.Apr 7 2020, 4:50 AM