Page MenuHomePhabricator

efl_text_formatter: rename from Efl.Text.Formatter to Efl.Text_Formatter
ClosedPublic

Authored by bu5hm4n on Apr 7 2020, 4:02 AM.

Details

Summary

this is needed in order to not collide with the Efl.Text Interface.
Theoretically eolian should have ordered on that, however, the checks
are buggy and only work out of tree.

ref T8648

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Apr 7 2020, 4:02 AM
bu5hm4n requested review of this revision.Apr 7 2020, 4:02 AM
segfaultxavi accepted this revision.Apr 7 2020, 4:23 AM
segfaultxavi added a subscriber: ali.alzyod.

Not much to discuss here, I think, but I'll bring @ali.alzyod since this is his creation.

This revision is now accepted and ready to land.Apr 7 2020, 4:23 AM

My comment is :
Are there anyway, to collect all these classes like (cursor,enums,textfomater,...) in new namespace, instead of adding them directly in EFL namespace ?

All the Input_Text classes are in the Efl.Input_Text namespace.
Cursor methods have been moved to the Efl.Text_Cursor namespace.
Text.Formatter has been moved to the root namespace as Efl.Text_Formatter. I agree it looks weird, but this whole class is weird, as we discussed some time ago...

I think adding another namespace would make things too verbose, and except the formatter class, the others don't look that bad.

Closed by commit rEFL8a155aecb6c9: efl_text_formatter: rename from Efl.Text.Formatter to Efl.Text_Formatter (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyApr 14 2020, 3:27 AM
This revision was automatically updated to reflect the committed changes.