exactness: use convinience ecore_file function to get dir
ClosedPublic
Actions

Authored by stefan_schmidt on Apr 17 2020, 6:53 AM.

Details

Reviewers

bu5hm4n
zmike

Commits

rEFLd4c8bd4f4fcd: exactness: use convinience ecore_file function to get dir

Summary

Instead of doing our own parsing here we should use ecore_file_dir_get()
which uses dirname() already to solve this.

CID: 1422196

Depends on D11726

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

stefan_schmidt created this revision.Apr 17 2020, 6:53 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

stefan_schmidt requested review of this revision.Apr 17 2020, 6:53 AM

stefan_schmidt added a child revision: D11728: exactness: make sure we handle a negative file descriptor.

stefan_schmidt added reviewers: bu5hm4n, zmike.Apr 17 2020, 6:58 AM

Harbormaster completed remote builds in B16610: Diff 30028.Apr 17 2020, 7:02 AM

I am wondering if we coudln't use just dirname... that should also handle all the escaping correctly, which is not the case here i think.

That could make sense. I can have a look tomorrow.

Dirname has its quirks (some implementatiosn modify the inout, etc) but we already have ecore_file_dir_get() :-) Changing it now.

witch to ecore_file_dir_get

Harbormaster completed remote builds in B16629: Diff 30058.Apr 21 2020, 6:25 AM

From memory, I think path now needs to be freed.

This revision now requires changes to proceed.Apr 21 2020, 6:55 AM

free up return

Your memory serves you right.

Harbormaster completed remote builds in B16631: Diff 30060.Apr 21 2020, 7:19 AM

stefan_schmidt added a child revision: D11753: exactness: check action for NULL.Apr 23 2020, 2:16 AM

stefan_schmidt added a child revision: D11754: exactness: check action for NULL.Apr 23 2020, 2:50 AM

Ready to land?

bu5hm4n accepted this revision.Apr 23 2020, 2:55 AM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 23 2020, 4:07 AM

Closed by commit rEFLd4c8bd4f4fcd: exactness: use convinience ecore_file function to get dir (authored by stefan_schmidt). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/bin/exactness/player.c (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	30028	b1ebdc4		Apr 17 2020, 6:53 AM	★	★
Diff 2	30058	738be4b	witch to ecore_file_dir_get	Apr 21 2020, 6:25 AM	★	★
Diff 3	30060	738be4b	free up return	Apr 21 2020, 7:17 AM	★	★
Diff 4	30083	7452700	rEFLd4c8bd4f4fcdca9aa18c2c9400fb8a1f6449e7a5	Apr 23 2020, 4:06 AM	★	★

Status	Author	Revision
Closed	stefan_schmidt	D11728 exactness: make sure we handle a negative file descriptor
Abandoned	stefan_schmidt	D11753 exactness: check action for NULL
Closed	stefan_schmidt	D11754 exactness: check action for NULL
Closed	stefan_schmidt	D11727 exactness: use convinience ecore_file function to get dir
Closed	stefan_schmidt	D11726 exactness: do not access potential NULL pointer
Closed	stefan_schmidt	D11725 exactness: make sure we handle a negative file descriptor
Closed	stefan_schmidt	D11724 exactness: handle case where eet_data_image_write() fails
Closed	stefan_schmidt	D11723 exactness: remove unused code

Diff 30083

View Options

src/bin/exactness/player.c