Page MenuHomePhabricator

tree-wide: Remove unneeded white spaces
ClosedPublic

Authored by elyes on May 6 2020, 12:15 AM.

Details

Summary

Remove unnecessary white spaces

Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>

Diff Detail

Repository
rE core/enlightenment
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elyes created this revision.May 6 2020, 12:15 AM
elyes requested review of this revision.May 6 2020, 12:15 AM
devilhorns resigned from this revision.May 6 2020, 6:28 AM

Same comment on missing email and commit message as for D11778

stefan_schmidt requested changes to this revision.May 13 2020, 3:00 AM
This revision now requires changes to proceed.May 13 2020, 3:00 AM

Changes itself look fine to me

elyes retitled this revision from Remove unneeded white spaces to tree-wide: Remove unneeded white spaces.May 13 2020, 12:38 PM
elyes edited the summary of this revision. (Show Details)

ok, seems some more explanation is needed.

Using tree-wide makes only sense if you fix one thing all over the tree (like the typo fixes you did).

When you write tree-wide here but only target a few files that does not make sense. I know I asked for splitting the big patch up for review purpose.

If you have so many changes all over the place it makes sense to group them. For example:

modules: fix whitespaces
e_fm: remove extra whitespaces
e_config: ...

like this.

I know, all kind of expections and rules when starting contributing. :-) Happy to work with you on getting things in shape.
Fixing it up for this commit as an example. Would be great if you could rework the other ones you submitted.

This revision was not accepted when it landed; it landed in state Needs Revision.May 14 2020, 3:18 AM
This revision was automatically updated to reflect the committed changes.