Page MenuHomePhabricator

build: enable -Wfloat-compare by default for dev builds

Authored by zmike on May 7 2020, 11:48 AM.

Diff Detail

rEFL core/efl
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.May 7 2020, 11:48 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added:

zmike requested review of this revision.May 7 2020, 11:48 AM

I confirm that this whole stack builds without warnings and passes all tests on my machine.
Given that floating point comparisons can be picky, I guess we should see Travis results to be extra sure.

segfaultxavi accepted this revision.May 12 2020, 1:10 AM

Awesome! Extra compiler checks enabled by default!

This revision is now accepted and ready to land.May 12 2020, 1:10 AM
This revision was automatically updated to reflect the committed changes.