Page MenuHomePhabricator

evas_vg_node: deprecate evas_vg_node_geometry_set.
ClosedPublic

Authored by jsuya on May 10 2020, 7:06 PM.

Details

Summary

The geometry info of evas_vg_node is based on Efl.Path_Bounds.
The size of vg_node does not change unless path data is changed.
Therefore, this API does not work normally.

Test Plan

N/A

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jsuya created this revision.May 10 2020, 7:06 PM
jsuya requested review of this revision.May 10 2020, 7:06 PM
Hermet requested changes to this revision.May 10 2020, 8:33 PM

Please check a comment.

src/lib/evas/canvas/efl_canvas_vg_node.c
745

No you don't need to change the behavior.

This revision now requires changes to proceed.May 10 2020, 8:33 PM
jsuya updated this revision to Diff 30196.May 10 2020, 11:07 PM

Update code

jsuya marked an inline comment as done.May 10 2020, 11:07 PM
Hermet requested changes to this revision.May 11 2020, 12:32 AM

Please check a comment.

src/lib/evas/Evas_Legacy.h
3917

you can just add @deprecated tag as like this instead of a comment.

  • @param[in] h The h geometry of the given object.
  • @since 1.24
  • @deprecated
src/lib/evas/canvas/efl_canvas_vg_node.c
744

This is uncesesary change, compiler will catch the deprecated api usages.

This revision now requires changes to proceed.May 11 2020, 12:32 AM
jsuya updated this revision to Diff 30197.May 11 2020, 12:42 AM

Thank you for review. Update code.

jsuya marked 2 inline comments as done.May 11 2020, 5:11 PM
Hermet accepted this revision.May 11 2020, 7:11 PM
This revision is now accepted and ready to land.May 11 2020, 7:11 PM
This revision was automatically updated to reflect the committed changes.