Page MenuHomePhabricator

Efl.Ui.Check_Legacy: Prevent unnecessary signal emit for contents
ClosedPublic

Authored by jsuya on May 11 2020, 10:25 PM.

Details

Summary

When call elm_check_add, theme_apply of layout is called and
_efl_ui_check_legacy_efl_ui_widget_theme_apply is called.
Then it calls the signal emit for the icon.
this call is unnecessary.

Test Plan

N/A

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jsuya created this revision.May 11 2020, 10:25 PM
jsuya requested review of this revision.May 11 2020, 10:25 PM
jsuya updated this revision to Diff 30213.May 11 2020, 10:45 PM

update code

jsuya updated this revision to Diff 30223.May 12 2020, 5:49 AM

Update code - use efl_finalized_get

jsuya updated this revision to Diff 30224.May 12 2020, 5:51 AM
jsuya edited the test plan for this revision. (Show Details)

I removed speed comparison. There are some improvements, but almost the same speed.

zmike accepted this revision.May 12 2020, 8:19 AM
This revision is now accepted and ready to land.May 12 2020, 8:19 AM
This revision was automatically updated to reflect the committed changes.