Page MenuHomePhabricator

elm_genlist/elm_gengrid: fix memory leak caused by efl_wref_del.
ClosedPublic

Authored by eagleeye on Thu, May 21, 2:15 AM.

Details

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
eagleeye created this revision.Thu, May 21, 2:15 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

eagleeye requested review of this revision.Thu, May 21, 2:15 AM
eagleeye edited the summary of this revision. (Show Details)
eagleeye updated this revision to Diff 30359.Thu, May 21, 2:28 AM

fix indentation

SanghyeonLee accepted this revision.Thu, May 21, 2:36 AM

Thank you very much!

This revision is now accepted and ready to land.Thu, May 21, 2:36 AM
Closed by commit rEFLc493e80c216c: elm_genlist/elm_gengrid: fix memory leak caused by efl_wref_del. (authored by Hosang Kim <hosang12.kim@samsung.com>, committed by SanghyeonLee). · Explain WhyThu, May 21, 2:37 AM
This revision was automatically updated to reflect the committed changes.

Uhm, this here is kind of wrong. You can simply efl_del the object, if the object is still there after wards, you can simply delete the wref. Additionally, NULL'ing it out is also not really needed.
I think you can safe quite a few calls with fixing this, and make the code easier.