Page MenuHomePhabricator

ecore_wl2_window: do not unmap subsurface in hide

Authored by kimcinoo on May 22 2020, 2:20 AM.



If window_hide should unmap subsurface, then window_show should re-map
the unmapeed subsurface. I have no idea why window_hide unmap all subsurfs.

Diff Detail

rEFL core/efl
No Linters Available
No Unit Test Coverage
Build Status
Buildable 16802
Build 11169: arc lint + arc unit
kimcinoo created this revision.May 22 2020, 2:20 AM
kimcinoo requested review of this revision.May 22 2020, 2:20 AM
devilhorns requested changes to this revision.May 22 2020, 5:23 AM
devilhorns added a subscriber: devilhorns.

Not sure this patch makes sense. If we are hiding the main surface the any subsurfaces of that main surface should be hidden yes, perhaps window_show should also be showing the subsurfaces ? Perhaps you could explain the issue and why this patch is necessary ??

This revision now requires changes to proceed.May 22 2020, 5:23 AM
zmike accepted this revision.May 22 2020, 5:43 AM

From Wayland protocol:

A sub-surface becomes mapped, when a non-NULL wl_buffer is applied
and the parent surface is mapped. The order of which one happens
first is irrelevant. A sub-surface is hidden if the parent becomes
hidden, or if a NULL wl_buffer is applied. These rules apply
recursively through the tree of surfaces.

It seems to me like this patch is correct; map and unmap of subsurfaces is handled solely based on the compositor, and there's no need to change these states in the client unnecessarily.

@devilhorns there is not an issue yet. I read ecore_wl2_surface_create and its relevant lines, and found this. I am not sure if this change is correct way or not. So I need to listen your valuable voice and @zmike as well. If unmap in hide, then re-map in show?

devilhorns accepted this revision.May 26 2020, 8:48 AM
This revision is now accepted and ready to land.May 26 2020, 8:48 AM
devilhorns closed this revision.May 26 2020, 8:49 AM