Page MenuHomePhabricator

elm_hoversel: Add missing resize_job's free
ClosedPublic

Authored by jsuya on Jun 1 2020, 7:28 PM.

Details

Summary

resize_job can be called after obj is deleted.
So add free to destructor.

Test Plan

N/A

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16893
Build 11228: arc lint + arc unit
jsuya created this revision.Jun 1 2020, 7:28 PM
jsuya requested review of this revision.Jun 1 2020, 7:28 PM
Hermet requested changes to this revision.Jun 1 2020, 8:03 PM

Please check comments.

src/lib/elementary/elc_hoversel.c
254

You should not delete job here.
Job will be deleted after this sizing_eval() when it's necesary,
Thus, just leave to nulling.

255

ELM_SAFE_FREE() do this nulling . so you don't need it again.

This revision now requires changes to proceed.Jun 1 2020, 8:03 PM
jsuya updated this revision to Diff 30499.Jun 1 2020, 8:12 PM

Update code

jsuya updated this revision to Diff 30500.Jun 1 2020, 8:15 PM
jsuya edited the summary of this revision. (Show Details)

update comment

jsuya marked 2 inline comments as done.Jun 1 2020, 8:15 PM
Hermet accepted this revision.Jun 1 2020, 8:26 PM
This revision is now accepted and ready to land.Jun 1 2020, 8:26 PM
Hermet closed this revision.Jun 1 2020, 8:28 PM